From d5e70c6610a16dfda6151039cc92d19fa7b8ff00 Mon Sep 17 00:00:00 2001 From: William Jacoby Date: Sun, 27 Sep 2026 18:20:01 -0500 Subject: [PATCH 1/2] Add the standard phpBB extension tests workflow Co-Authored-By: Claude Opus 5.5 --- .github/workflows/tests.yml | 50 +++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 .github/workflows/tests.yml diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml new file mode 100644 index 0000000..1ccc108 --- /dev/null +++ b/.github/workflows/tests.yml @@ -0,0 +1,50 @@ +name: Tests + +# For most extensions, this workflow should not need changing; +# simply commit it to your repository. +# +# See the README for full details and configuration instructions: +# - https://github.com/phpbb-extensions/test-framework +# +on: + push: + # Run tests when commits are pushed to these branches in your repo, + # or remove this branches section to run tests on all your branches + branches: + - master + + pull_request: + # Run tests when pull requests are made on these branches in your repo, + # or remove this branches section to run tests on all your branches + branches: + - master + +jobs: + call-tests: + name: Extension tests + # Set the phpBB branch to test your extension with after the @ symbol + # - 3.3.x: Targets the phpBB 3.3.x release line + # - master: Targets the latest development version of phpBB (master branch) + uses: phpbb-extensions/test-framework/.github/workflows/tests.yml@3.3.x + with: + # Your extension vendor/package name + EXTNAME: phpbbmodders/groupswitches + + # Run MySQL/MariaDB tests? + RUN_MYSQL_JOBS: 0 + + # Run PostgreSQL tests? + RUN_PGSQL_JOBS: 0 + + # Run MSSQL and SQLite3 tests? + RUN_MSSQL_JOBS: 0 + + # Run Windows IIS & PostgreSQL tests? + RUN_WINDOWS_JOBS: 0 + + # Preferred PHP version used for all test jobs. + PRIMARY_PHP_VERSION: '8.2' + + # The MySQL and PostgreSQL jobs run tests across multiple PHP versions. + # List the PHP versions you want your extension tested with. + PHP_VERSION_MATRIX: '["8.2", "8.3", "8.4"]' From 8c5401c6a5b03cec4b01293182b03707b2c9d232 Mon Sep 17 00:00:00 2001 From: William Jacoby Date: Sun, 27 Sep 2026 18:24:20 -0500 Subject: [PATCH 2/2] Quote service arguments so phpBB 3.3 can parse services.yml, and fix packaging Unquoted @/% values are a YAML parse error in the Symfony version phpBB 3.3 ships, so the extension couldn't load there. Also fix the soft-require constraint syntax EPV rejects and rename license.txt.txt to license.txt. Co-Authored-By: Claude Opus 5.5 --- composer.json | 2 +- config/services.yml | 8 ++++---- license.txt.txt => license.txt | 0 3 files changed, 5 insertions(+), 5 deletions(-) rename license.txt.txt => license.txt (100%) diff --git a/composer.json b/composer.json index 52cd361..de03b4d 100644 --- a/composer.json +++ b/composer.json @@ -36,7 +36,7 @@ "extra": { "display-name": "Group Switches", "soft-require": { - "phpbb/phpbb": ">=3.1.0-RC2,<3.2.*@dev" + "phpbb/phpbb": ">=3.1.0-RC2,<3.2@dev" } } } diff --git a/config/services.yml b/config/services.yml index 167bc97..e7c4b4c 100644 --- a/config/services.yml +++ b/config/services.yml @@ -2,10 +2,10 @@ services: phpbbmodders.groupswitches.listener: class: phpbbmodders\groupswitches\event\listener arguments: - - @template - - @user - - %core.root_path% - - %core.php_ext% + - '@template' + - '@user' + - '%core.root_path%' + - '%core.php_ext%' tags: - { name: event.listener } diff --git a/license.txt.txt b/license.txt similarity index 100% rename from license.txt.txt rename to license.txt