You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 98a5d19
Browse filesBrowse the repository at this point in the historyBrowse files
feat: add an elonw feature check and screenshot recipe (#61)
Adds a feature check and a screenshot recipe for phpbbmodders/elonw.
**Feature check** (`feature_checks.py`)
- Posts an external link and a link to the board, then checks in Chromium that:
- only the external link is marked, with a tooltip and the same text for screen readers;
- it opens in a new window, also after a script-driven link was clicked;
- the link to the board opens in the same window.
- Saves the UCP setting as 0, -1 and 1, and checks what is stored and that turning it off removes the script.
- Answers requests to other hosts locally, so nothing leaves the machine.
**Screenshot recipe** (`screenshots.py`)
- Saves a post with both kinds of link and the UCP setting. Documented in the README.
**Testing**
Claude ran these checks:
- `db-matrix.sh` with the check on phpBB 3.3 and 4.0 with SQLite, MySQL, MariaDB, PostgreSQL and SQL Server.
- On the elonw code from before its fixes, the check fails the screen-reader, new-window and stored-value cases.
- `tests/test-phpbb-test-board.sh` passes.
- The recipe produced the screenshots in the elonw PR.
---
Investigated and written by [Claude](https://www.anthropic.com/claude) on behalf of William Jacoby ([bonelifer](https://github.com/bonelifer)).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Copy file name to clipboardExpand all lines: phpbb-test-board/README.md
+2Lines changed: 2 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -138,6 +138,8 @@ Saves PNG screenshots of an extension's or style's pages with [Playwright](https
138
138
139
139
`phpbbmodders/autodbbackup` saves its ACP settings set to daily gzip backups keeping seven, then runs the backup cron twice and saves phpBB's ACP Restore page listing the two backups, which it deletes afterwards.
140
140
141
+
`phpbbmodders/elonw` rewrites the first post of the busiest topic to hold an external link and a link to the board itself, then saves that post, showing the new-window icon on the external link only, and the UCP setting. Use `--seed` with seed-forum's standard fixtures.
142
+
141
143
`phpbbmodders/genders` gives every member a gender and saves the UCP selector, a topic, a profile and the ACP settings with the defaults, then the same topic, profile and settings with gender text before the icon, the phpBB 3.0 MOD prosilver icon set and gender in the main profile details. Use `--seed` with seed-forum's standard fixtures.
142
144
143
145
`phpbbmodders/knowledgebase` makes its own categories, articles (live, waiting for review, with a revision, and a draft) and forum questions, so a board search for `backup` shows its block; `--seed` with seed-forum's standard fixtures adds members to write them. Its two ACP pages are taken in full, so a new setting is not cut off.
0 commit comments