Repository navigation
feature_checks: cover Auto Database Backup scheduling and retention - #51
Merged
Merged
Conversation
Extend the current phpbbmodders/autodbbackup check with exact start, delayed cadence, readiness, and private archive assertions while preserving existing coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the existing Auto Database Backup check to verify the exact ACP-selected start time, readiness of an overdue backup, preserved cadence after a late run, and nonempty custom-directory archives with private
0600permissions.Preserves the current retention, manual-backup, ACP Restore, optimization, and directory-validation coverage, using the
phpbbmodders/autodbbackupregistration and cron task. Conflicts with main are resolved.Testing
Codex ran the feature and disable/purge/enable checks on phpBB 3.3.19 and 4.0.0-a3-dev with SQLite, MySQL, MariaDB, PostgreSQL, and MSSQL: all ten combinations passed 30 checks each. The test-board option suite, Python compilation, diff whitespace check, and GitHub CI also passed.
Investigated and written by Codex on behalf of William Jacoby (bonelifer).