Repository navigation
feat: add a seenotes feature check and screenshot recipe - #62
Merged
Merged
Conversation
check_seenotes covers the ACP settings and reasons, giving a reason and BBCode notes in the MCP, who sees the reason line where, NONE, ACP Manage users, confirm-box deletes, logging, member deletion and the two-step reason delete. The screenshot recipe uses seed-forum's See Notes fixtures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Pushed e3a178d: the check now also confirms that See Notes adds its seven starter reasons when it is enabled (phpbbmodders/seenotes#7). Claude ran it through Investigated and written by Claude on behalf of William Jacoby (bonelifer). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
phpbbmodders/seenotesto the test tools, for its first build (phpbbmodders/seenotes#2).feature_checks.py:check_seenotesconfirms the seven starter reasons are added on enable, saves the ACP settings, refuses a reason without a required description, adds a reason, gives a member that reason in the MCP, saves a note with a quote and edits it, and checks that staff see the reason line on the topic page, profile, MCP post details and MCP topic view while guests and members do not. It also covers ACP Manage users, deleting a note through the confirm box, the log entries, deleting a member, the two-step reason delete with a wrong and a right name, and NONE for a member without a current reason.screenshots.py:shots_seenotesruns seed-forum's newbin/seed-seenotes-fixtures.php(phpbbmodders/seed-forum, separate pull request) after the standard fixtures, then saves eight board, MCP and ACP shots.phpbb-test-board/README.mddescribes the screenshot recipe.Claude ran the feature check on phpBB 3.3 and 4.0 with SQLite, MySQL, MariaDB, PostgreSQL and MSSQL through
db-matrix.sh, took the screenshots with the recipe, and rantests/test-phpbb-test-board.sh.Investigated and written by Claude on behalf of William Jacoby (bonelifer).