Repository navigation
seenotes: check the notes button instead of NONE - #63
Merged
Merged
Conversation
check_seenotes now checks that a member without a current reason has no reason line while staff get the notes button and profile link to the Give a reason form, and that members and guests get neither. The screenshot recipe shows the button on a post by a member without a reason instead of NONE. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the See Notes checks for phpbbmodders/seenotes replacing "SEE NOTES: NONE" with a notes button.
feature_checks.py: for a member without a current reason,check_seenotesnow checks that no reason line shows, and that the notes button next to their post and the profile's Moderator notes link both open the Give a reason form. It also checks that members and guests get neither.screenshots.py: the NONE profile shot is replaced by a post from a member without a reason, showing the button.phpbb-test-board/README.mddescribes the new shot.Claude ran the check through
db-matrix.shon both branches and all five databases, and took the screenshots with the recipe.Investigated and written by Claude on behalf of William Jacoby (bonelifer).