Repository navigation
Add prunenotifications feature check and screenshots - #64
Merged
Merged
Conversation
The feature check makes a member dormant with 250 notifications, then covers the settings and their range check, Prune now in batches through the confirm box and meta refreshes, the optimize after pruning, Optimize now, and the cron task working through a backlog with one log entry. The screenshots show the ACP page, the confirmation and the finished prune. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a feature check and a screenshot recipe for phpbbmodders/prunenotifications.
feature_checks.py:check_prunenotificationsmakes one member dormant with 250 notifications and gives the admin 5. It then checks that the settings save and that an out-of-range period is refused, then runs Prune now through the confirm box and its meta-refresh batches. It confirms the dormant notifications are gone, the admin's are kept, and the prune is logged. It also covers the optimize after pruning, Optimize now, and the cron task clearing a 150-notification backlog in two runs with a single log entry. Afterwards it restores the member and turns the settings back off.screenshots.py:shots_prunenotificationsneeds--seed. It saves the ACP page, the Prune now confirmation and the finished prune.phpbb-test-board/README.md: the screenshot entry.Testing
db-matrix.shwith the extension on all ten boards (phpBB 3.3 and 4.0, each on SQLite, MySQL, MariaDB, PostgreSQL and MSSQL): 25/25 checks passed on every board.screenshots.pysaved all three images on a freshsetup-board.shboard.tests/test-phpbb-test-board.shpasses.🤖 Generated with Claude Code
Investigated and written by Claude on behalf of William Jacoby (bonelifer).