Repository navigation
Create enable-on-php.sh mount points as the user - #67
Merged
Merged
Conversation
Docker created each missing ext/VENDOR/NAME mount point as root, so the script's cleanup could not remove them and the board kept root-owned empty folders that only root could delete. The script now creates the mount points itself before starting Docker and removes only the folders it created, deepest first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable-on-php.shleft empty, root-owned folders in the board'sext/folder. Docker creates any missing mount point as root, so the script's own cleanup could not remove them, and deleting the board folder afterwards failed without root.The script now creates each
ext/VENDOR/NAMEmount point itself, as the calling user, before starting Docker. Afterwards it removes only the folders it created, deepest first, so a vendor folder that already existed (such asext/phpbb/) is left alone.Claude tested it on a fresh seed-forum SQLite board: a PHP 8.1 run enabling two extensions with
--disable, and a PHP 8.0 run where the extension refuses to enable. After both,ext/matched its state before the run, nothing in the board was root-owned, andext/phpbb/was still there.shellcheckpasses.🤖 Generated with Claude Code
Investigated and written by Claude on behalf of William Jacoby (bonelifer).