Repository navigation
Group Warn: full feature check and screenshot recipe; enable-on-php.sh clears the cache - #68
Merged
Merged
Conversation
…h clears the cache - feature_checks.py: the Group Warn check now also covers the warn button on posts and the warn link on profiles, the founder exception, and that pending group memberships don't count. - screenshots.py: new Group Warn recipe, the Group warn setting on the Registered users group's ACP page. - enable-on-php.sh: empty cache/production before starting, since a container compiled by the host's PHP 8.4 can't be parsed by PHP 8.3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MySQL, MariaDB and PostgreSQL boards return user_warnings as a string, so the warning-count checks failed there; SQL Server has no LIMIT. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test tooling for the Group Warn maintenance pass, and a fix to
enable-on-php.sh.feature_checks.py: the Group Warn check now also covers the warn button on posts and the warn link on profiles, the founder exception, and that pending group memberships do not block warnings while full ones do. 8 checks, up from 3. The warning-count comparisons now convert to numbers: MySQL, MariaDB and PostgreSQL boards return the count as a string, so the existing checks failed on those databases.screenshots.py: a new Group Warn recipe, showing the Group warn setting on the Registered users group's ACP page.enable-on-php.sh: empties the board'scache/productionbefore starting. A container compiled by the host's PHP 8.4 uses PHP 8.4-only syntax, so running phpBB's CLI under PHP 8.3 failed with a parse error. The README mentions it.Claude ran the extended check on a phpBB 3.3.19 board: 8 of 8 pass on the updated Group Warn, and the pending-membership check fails on the old code, as it should. With that fix it passed in all 10
db-matrix.shcells (phpBB 3.3.19 and 4.0.0-a3-dev on SQLite, MySQL, MariaDB, PostgreSQL and MSSQL). The recipe saved its screenshot.enable-on-php.shenabled Group Warn under PHP 8.3 on a phpBB 4.0 board whose cache the host's PHP 8.4 had just compiled, which failed before this change.shellcheckpasses.🤖 Generated with Claude Code
Investigated and written by Claude on behalf of William Jacoby (bonelifer).