Repository navigation
Feature check and screenshots for Translation Helper - #70
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed translation Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a feature check and a screenshot recipe for the new Translation Helper extension.
Feature check (
feature_checks.py)check_translationhelpermakes its own fixture extension (thcheck/demo) and a testsvlanguage, so it runs on a plainsetup-board.shboard and on any seed-forum board. It checks that:<?phpstay text), and a copy is saved instore/;It removes the fixture extension and its saved translation afterwards, since a database reset doesn't undo files.
Screenshots (
screenshots.py)shots_translationhelperuses seed-forum's Translation Helper fixtures (phpbbmodders/seed-forum#33) to save the extensions page with the "put back" notice, the editor with a changed string, the Older English versions page and the settings. It removes the fixture files afterwards. The README describes it.Testing
Claude ran the feature check on a
setup-board.shboard (14/14) and throughdb-matrix.shon phpBB 3.3 and 4.0 with SQLite, MySQL, MariaDB, PostgreSQL and MSSQL (18/18 on each board, including the disable/purge/enable round trip). The screenshot recipe produced the four images now in the extension'sdocs/images/screenshots/.Investigated and written by Claude on behalf of William Jacoby (bonelifer).