Skip to content

Feature check and screenshots for Translation Helper - #70

Merged
bonelifer merged 2 commits into
mainfrom
translationhelper-check
Nov 11, 2026
Merged

bonelifer merged 2 commits into
mainfrom
translationhelper-check

Conversation

@bonelifer

Copy link
Copy Markdown
Contributor

Adds a feature check and a screenshot recipe for the new Translation Helper extension.

Feature check (feature_checks.py)

check_translationhelper makes its own fixture extension (thcheck/demo) and a test sv language, so it runs on a plain setup-board.sh board and on any seed-forum board. It checks that:

  • the extensions page lists the fixture, and the editor shows its untranslated strings;
  • saving writes a language file that gives back exactly what was typed (quotes, a backslash, HTML and a literal <?php stay text), and a copy is saved in store/;
  • uploading a release ZIP, and uploading two loose language files in the one field, each add an older English version;
  • after the fixture's folder is replaced by a new version, the translation is put back, the extensions page says so, and the new string gets the English text;
  • the changed string shows its old and new English, and English text is shown escaped.

It removes the fixture extension and its saved translation afterwards, since a database reset doesn't undo files.

Screenshots (screenshots.py)

shots_translationhelper uses seed-forum's Translation Helper fixtures (phpbbmodders/seed-forum#33) to save the extensions page with the "put back" notice, the editor with a changed string, the Older English versions page and the settings. It removes the fixture files afterwards. The README describes it.

Testing

Claude ran the feature check on a setup-board.sh board (14/14) and through db-matrix.sh on phpBB 3.3 and 4.0 with SQLite, MySQL, MariaDB, PostgreSQL and MSSQL (18/18 on each board, including the disable/purge/enable round trip). The screenshot recipe produced the four images now in the extension's docs/images/screenshots/.


Investigated and written by Claude on behalf of William Jacoby (bonelifer).

bonelifer and others added 2 commits November 11, 2026 08:22
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed translation

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bonelifer
bonelifer merged commit 2e58c46 into main Nov 11, 2026
1 check passed
@bonelifer
bonelifer deleted the translationhelper-check branch November 11, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant