Share the runtime checks of findExtension() and isMissingNextToPhar()

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Author: 2 people

src/Turbo/TurboExtensionSelector.php

@@ -82,24 +82,15 @@ public static function findExtensionForWorkers(): ?string
 	 */
 	public static function isMissingNextToPhar(): bool
 	{
-		// no binary is built for these runtimes, so installing PHPStan with
-		// Composer would not bring the extension either (see findExtension())
-		if (PHP_VERSION_ID < self::MINIMUM_PHP_VERSION_ID || (bool) PHP_DEBUG) {
+		$platformDirectory = self::getPlatformDirectoryNextToPhar();
+		if ($platformDirectory === null) {
 			return false;
 		}
 		if (TurboExtensionEnabler::isLoaded()) {
 			return false;
 		}
 
-		$pharPath = Phar::running(false);
-		if ($pharPath === '') {
-			return false;
-		}
-		if (self::resolvePlatformDirectory(PHP_OS_FAMILY, php_uname('m'), self::isMusl()) === null) {
-			return false;
-		}
-
-		return !is_dir(dirname($pharPath) . '/turbo-ext');
+		return !is_dir(dirname($platformDirectory));
 	}
 
 	/**
@@ -108,27 +99,14 @@ public static function isMissingNextToPhar(): bool
 	 */
 	public static function findExtension(): ?string
 	{
-		if (PHP_VERSION_ID < self::MINIMUM_PHP_VERSION_ID) {
-			return null;
-		}
-		if ((bool) PHP_DEBUG) {
-			return null;
-		}
-
-		$pharPath = Phar::running(false);
-		if ($pharPath === '') {
-			return null;
-		}
-
-		$platform = self::resolvePlatformDirectory(PHP_OS_FAMILY, php_uname('m'), self::isMusl());
-		if ($platform === null) {
+		$platformDirectory = self::getPlatformDirectoryNextToPhar();
+		if ($platformDirectory === null) {
 			return null;
 		}
 
 		$file = sprintf(
-			'%s/turbo-ext/%s/phpstan_turbo-%d.%d%s.%s',
-			dirname($pharPath),
-			$platform,
+			'%s/phpstan_turbo-%d.%d%s.%s',
+			$platformDirectory,
 			PHP_MAJOR_VERSION,
 			PHP_MINOR_VERSION,
 			(bool) PHP_ZTS ? '-zts' : '',
@@ -147,6 +125,34 @@ public static function findExtension(): ?string
 		return $file;
 	}
 
+	/**
+	 * The directory of turbo-ext/ next to the running phar that holds the
+	 * binaries for this platform, whether it exists or not. Null when no
+	 * binary is built for this runtime: PHP older than the minimum, a debug
+	 * build, a run from source, or a platform without binaries.
+	 */
+	private static function getPlatformDirectoryNextToPhar(): ?string
+	{
+		if (PHP_VERSION_ID < self::MINIMUM_PHP_VERSION_ID) {
+			return null;
+		}
+		if ((bool) PHP_DEBUG) {
+			return null;
+		}
+
+		$pharPath = Phar::running(false);
+		if ($pharPath === '') {
+			return null;
+		}
+
+		$platform = self::resolvePlatformDirectory(PHP_OS_FAMILY, php_uname('m'), self::isMusl());
+		if ($platform === null) {
+			return null;
+		}
+
+		return sprintf('%s/turbo-ext/%s', dirname($pharPath), $platform);
+	}
+
 	/**
 	 * The shared core the extension binary loads, in the same directory.
 	 */