Add regression tests for #1946, #11919 and #13959

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014LVEGd9G9w8j64EZQ7rysC

Author: ondrejmirtes

tests/PHPStan/Analyser/nsrt/bug-13959.php

@@ -0,0 +1,34 @@
+<?php declare(strict_types = 1);
+
+namespace Bug13959;
+
+use InvalidArgumentException;
+use function PHPStan\Testing\assertType;
+
+interface GlobalId {}
+class GlobalTagId implements GlobalId {}
+
+class HelloWorld
+{
+	/**
+	 * @param list<GlobalId|string> $value
+	 */
+	public function sayHello(array $value): void
+	{
+		assertType('list<Bug13959\GlobalId|string>', $value);
+
+		foreach ($value as $item) {
+			if ($item instanceof GlobalTagId) {
+				continue;
+			}
+
+			if (is_string($item)) {
+				continue;
+			}
+
+			throw new InvalidArgumentException('Invalid type');
+		}
+		
+		assertType('list<Bug13959\GlobalTagId|string>', $value);
+	}
+}

tests/PHPStan/Analyser/nsrt/bug-1946.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace Bug1946;
+
+use function PHPStan\Testing\assertType;
+
+$tag = null;
+foreach (["a", "b", "c"] as $tag) {
+	if ($tag === "a") {
+		$tag = null;
+		break;
+	} elseif ($tag === "b") {
+		$tag = null;
+		break;
+	} else {
+		$tag = null;
+		break;
+	}
+}
+
+assertType('null', $tag);
+
+echo strlen($tag);

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -3178,4 +3178,20 @@ public function testBug11041(): void
 		$this->analyse([__DIR__ . '/data/bug-11041.php'], []);
 	}
 
+	public function testBug1946(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-1946.php'], [
+			[
+				'Parameter #1 $string of function strlen expects string, null given.',
+				19,
+			],
+		]);
+	}
+
+	#[RequiresPhp('>= 8.0.0')]
+	public function testBug11919(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-11919.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Functions/data/bug-11919.php

@@ -0,0 +1,24 @@
+<?php declare(strict_types = 1);
+
+namespace Bug11919;
+
+$handle = \fopen('some-file.csv', 'r');
+if ($handle === false)
+{
+	exit(1);
+}
+$row = \fgetcsv( $handle );
+while ( $row !== false )
+{
+	foreach ( ['a', 'b'] as $value )
+	{
+		// $row can never be false here
+		if ( ! \in_array('some-key', $row) )
+		{
+			exit(1);
+		}
+		$row = \fgetcsv( $handle );
+		// This shortcuts to the while loop - which eliminates false values
+	    continue 2;
+	}	
+}

tests/PHPStan/Rules/Functions/data/bug-1946.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace Bug1946;
+
+$tag = null;
+foreach (["a", "b", "c"] as $tag) {
+	if ($tag === "a") {
+		$tag = null;
+		break;
+	} elseif ($tag === "b") {
+		$tag = null;
+		break;
+	} else {
+		$tag = null;
+		break;
+	}
+}
+
+echo strlen($tag);