Cover the sealed key-set shortcut against shapes of unknown sealedness

The shortcut in ConstantArrayType::isSuperTypeOf() only applies when both
shapes are sealed: a shape of unknown sealedness accepts extra keys, so
a required key it lacks decides nothing. isKeyIndexMiss() no longer asks
isConstantScalarValue() first - a non-compound type has a single int or
string constant scalar value only when it is that constant.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1b24f-ec49-7194-bbd2-0f4a43ab9b8f

Author: ondrejmirtes

src/Type/Constant/ConstantArrayType.php

@@ -3318,7 +3318,7 @@ private function findVerifiedKeyIndex(Type $offsetType): ?int
 	 */
 	private function isKeyIndexMiss(Type $offsetType): bool
 	{
-		if ($offsetType instanceof CompoundType || !$offsetType->isConstantScalarValue()->yes()) {
+		if ($offsetType instanceof CompoundType) {
 			return false;
 		}
 

tests/PHPStan/Type/Constant/ConstantArrayTypeTest.php

@@ -934,6 +934,30 @@ public static function dataIsSuperTypeOfWithoutBleedingEdge(): array
 				]),
 				TrinaryLogic::createYes(),
 			],
+			// the same with the other shape sealed: its extra required key does not decide anything
+			[
+				new ConstantArrayType([new ConstantStringType('a')], [new StringType()]),
+				new ConstantArrayType([
+					new ConstantStringType('a'),
+					new ConstantStringType('b'),
+				], [
+					new StringType(),
+					new IntegerType(),
+				], unsealed: [new NeverType(true), new NeverType(true)]),
+				TrinaryLogic::createYes(),
+			],
+			// a sealed shape against one with unknown sealedness and an extra required key
+			[
+				new ConstantArrayType([new ConstantStringType('a')], [new StringType()], unsealed: [new NeverType(true), new NeverType(true)]),
+				new ConstantArrayType([
+					new ConstantStringType('a'),
+					new ConstantStringType('b'),
+				], [
+					new StringType(),
+					new IntegerType(),
+				]),
+				TrinaryLogic::createYes(),
+			],
 		]);
 	}
 

turbo-ext/src/ConstantArrayType.cpp

@@ -5216,9 +5216,6 @@ class ConstantArrayType
 		bool compound;
 		if (UNEXPECTED(!isInstance(offsetType, PT_CLASS_COMPOUND_TYPE, compound))) return false;
 		if (compound) return true;
-		zend_long isConstantScalar = pt_type_op_trinary(Z_OBJ_P(offsetType), PT_OP_IS_CONSTANT_SCALAR_VALUE, 0, NULL);
-		if (UNEXPECTED(isConstantScalar < 0)) return false;
-		if (isConstantScalar != PT_TRI_YES) return true;
 
 		zv::Val values = pt_type_call_array(Z_OBJ_P(offsetType), PT_LC("getconstantscalarvalues"), 0, NULL);
 		if (UNEXPECTED(values.isUndef())) return false;