Cover the pre-PHP 8 parameter names for the by-ref out-parameter builtins

str_replace/str_ireplace's count and preg_match/preg_match_all's matches
resolve to different parameter names (replace_count/subpatterns) when the
target PHP version is below 8.0: NativeFunctionReflectionProvider falls
back from php-8-stubs to the legacy functionMap.php names in that case.
List both names in the metadata so the by-ref-omitted suppression works
regardless of the analysed PHP version. Found via the old-PHPUnit (7.4) CI
job, which runs the test suite against phpVersion 7.4 by default.

Author: zonuexe

bin/functionMetadata_original.php

@@ -268,8 +268,10 @@
 	'output_reset_rewrite_vars' => ['hasSideEffects' => true],
 	'pclose' => ['hasSideEffects' => true],
 	'popen' => ['hasSideEffects' => true],
-	'preg_match' => ['pureUnlessParameterPassedParameters' => ['matches' => true]],
-	'preg_match_all' => ['pureUnlessParameterPassedParameters' => ['matches' => true]],
+	// 'matches'/'subpatterns': PHP 8+ uses the php-8-stubs parameter name, PHP <8 falls
+	// back to the legacy functionMap.php name.
+	'preg_match' => ['pureUnlessParameterPassedParameters' => ['matches' => true, 'subpatterns' => true]],
+	'preg_match_all' => ['pureUnlessParameterPassedParameters' => ['matches' => true, 'subpatterns' => true]],
 	'preg_replace' => ['pureUnlessParameterPassedParameters' => ['count' => true]],
 	'preg_replace_callback' => ['pureUnlessCallableIsImpureParameters' => ['callback' => true]],
 	'similar_text' => ['pureUnlessParameterPassedParameters' => ['percent' => true]],
@@ -280,8 +282,10 @@
 	'sprintf' => ['hasSideEffects' => false],
 	'str_decrement' => ['hasSideEffects' => false],
 	'str_increment' => ['hasSideEffects' => false],
-	'str_ireplace' => ['pureUnlessParameterPassedParameters' => ['count' => true]],
-	'str_replace' => ['pureUnlessParameterPassedParameters' => ['count' => true]],
+	// 'count'/'replace_count': PHP 8+ uses the php-8-stubs parameter name, PHP <8 falls
+	// back to the legacy functionMap.php name.
+	'str_ireplace' => ['pureUnlessParameterPassedParameters' => ['count' => true, 'replace_count' => true]],
+	'str_replace' => ['pureUnlessParameterPassedParameters' => ['count' => true, 'replace_count' => true]],
 	'symlink' => ['hasSideEffects' => true],
 	'time' => ['hasSideEffects' => true],
 	'tempnam' => ['hasSideEffects' => true],

resources/functionMetadata.php

@@ -1637,8 +1637,8 @@
 	'preg_grep' => ['hasSideEffects' => false],
 	'preg_last_error' => ['hasSideEffects' => true],
 	'preg_last_error_msg' => ['hasSideEffects' => true],
-	'preg_match' => ['pureUnlessParameterPassedParameters' => ['matches' => true]],
-	'preg_match_all' => ['pureUnlessParameterPassedParameters' => ['matches' => true]],
+	'preg_match' => ['pureUnlessParameterPassedParameters' => ['matches' => true, 'subpatterns' => true]],
+	'preg_match_all' => ['pureUnlessParameterPassedParameters' => ['matches' => true, 'subpatterns' => true]],
 	'preg_quote' => ['hasSideEffects' => false],
 	'preg_replace' => ['pureUnlessParameterPassedParameters' => ['count' => true]],
 	'preg_replace_callback' => ['pureUnlessCallableIsImpureParameters' => ['callback' => true]],
@@ -1687,10 +1687,10 @@
 	'str_ends_with' => ['hasSideEffects' => false],
 	'str_getcsv' => ['hasSideEffects' => false],
 	'str_increment' => ['hasSideEffects' => false],
-	'str_ireplace' => ['pureUnlessParameterPassedParameters' => ['count' => true]],
+	'str_ireplace' => ['pureUnlessParameterPassedParameters' => ['count' => true, 'replace_count' => true]],
 	'str_pad' => ['hasSideEffects' => false],
 	'str_repeat' => ['hasSideEffects' => false],
-	'str_replace' => ['pureUnlessParameterPassedParameters' => ['count' => true]],
+	'str_replace' => ['pureUnlessParameterPassedParameters' => ['count' => true, 'replace_count' => true]],
 	'str_rot13' => ['hasSideEffects' => false],
 	'str_split' => ['hasSideEffects' => false],
 	'str_starts_with' => ['hasSideEffects' => false],