Do not attach the positional-arguments fix to the callback call synthesized from call_user_func() / call_user_func_array() (#6966)

Author: phpstan-bot

src/Rules/FunctionCallParametersCheck.php

@@ -56,6 +56,12 @@
 final class FunctionCallParametersCheck
 {
 
+	/**
+	 * Marks a call node that was synthesized from a different node (e.g. the callback call of call_user_func()),
+	 * its arguments do not correspond to the arguments of the node in the file, so it cannot be fixed.
+	 */
+	public const NOT_FIXABLE_CALL_ATTRIBUTE = 'phpstanNotFixableCall';
+
 	public function __construct(
 		private RuleLevelHelper $ruleLevelHelper,
 		private NullsafeCheck $nullsafeCheck,
@@ -912,8 +918,11 @@ private function createPositionalArgumentsFix(
 		Node\Expr\FuncCall|Node\Expr\MethodCall|Node\Expr\StaticCall|Node\Expr\New_ $funcCall,
 	): Closure|false
 	{
-		if ((bool) $funcCall->getAttribute('isAttribute', false)) {
+		if (
 			// the call was created from an attribute, it is not in the file
+			(bool) $funcCall->getAttribute('isAttribute', false)
+			|| (bool) $funcCall->getAttribute(self::NOT_FIXABLE_CALL_ATTRIBUTE, false)
+		) {
 			return false;
 		}
 

src/Rules/Functions/CallUserFuncRule.php

@@ -69,6 +69,7 @@ public function processNode(Node $node, Scope&NodeCallbackInvoker&CollectedDataE
 			return [];
 		}
 		[$parametersAcceptor, $funcCall, $acceptsNamedArguments] = $result;
+		$funcCall->setAttribute(FunctionCallParametersCheck::NOT_FIXABLE_CALL_ATTRIBUTE, true);
 
 		$callableDescription = sprintf('callable passed to %s()', $functionName);
 

tests/PHPStan/Rules/Functions/CallUserFuncRuleTest.php

@@ -202,4 +202,10 @@ public function testConstantParameterCheckCallUserFunc(): void
 		]);
 	}
 
+	#[RequiresPhp('>= 8.0.0')]
+	public function testBug15664(): void
+	{
+		$this->fix(__DIR__ . '/data/bug-15664.php', __DIR__ . '/data/bug-15664.php.fixed');
+	}
+
 }

tests/PHPStan/Rules/Functions/data/bug-15664.php

@@ -0,0 +1,38 @@
+<?php // lint >= 8.0
+
+namespace Bug15664;
+
+/**
+ * @no-named-arguments
+ */
+final class ParallelConfigFactory
+{
+
+	public static function detect(
+		?int $filesPerProcess = null,
+		?int $processTimeout = null,
+		?int $maxProcesses = null
+	): void
+	{
+	}
+
+}
+
+function doFoo(): void
+{
+	\call_user_func_array([ParallelConfigFactory::class, 'detect'], ['processTimeout' => 300]);
+
+	\call_user_func_array([ParallelConfigFactory::class, 'detect'], [
+		'maxProcesses' => 1,
+		'processTimeout' => 300,
+		'filesPerProcess' => 5,
+	]);
+
+	\call_user_func_array([ParallelConfigFactory::class, 'detect'], ['filesPerProcess' => 7]);
+
+	\call_user_func_array([ParallelConfigFactory::class, 'detect'], ['maxProcesses' => 1]);
+
+	\call_user_func([ParallelConfigFactory::class, 'detect'], processTimeout: 300);
+
+	\call_user_func([ParallelConfigFactory::class, 'detect'], filesPerProcess: 7);
+}

tests/PHPStan/Rules/Functions/data/bug-15664.php.fixed

@@ -0,0 +1,38 @@
+<?php // lint >= 8.0
+
+namespace Bug15664;
+
+/**
+ * @no-named-arguments
+ */
+final class ParallelConfigFactory
+{
+
+	public static function detect(
+		?int $filesPerProcess = null,
+		?int $processTimeout = null,
+		?int $maxProcesses = null
+	): void
+	{
+	}
+
+}
+
+function doFoo(): void
+{
+	\call_user_func_array([ParallelConfigFactory::class, 'detect'], ['processTimeout' => 300]);
+
+	\call_user_func_array([ParallelConfigFactory::class, 'detect'], [
+		'maxProcesses' => 1,
+		'processTimeout' => 300,
+		'filesPerProcess' => 5,
+	]);
+
+	\call_user_func_array([ParallelConfigFactory::class, 'detect'], ['filesPerProcess' => 7]);
+
+	\call_user_func_array([ParallelConfigFactory::class, 'detect'], ['maxProcesses' => 1]);
+
+	\call_user_func([ParallelConfigFactory::class, 'detect'], processTimeout: 300);
+
+	\call_user_func([ParallelConfigFactory::class, 'detect'], filesPerProcess: 7);
+}