Treat all in-scope variables as used when a closure or constructor body contains include/require/eval (#6056)

Co-authored-by: staabm <120441+staabm@users.noreply.github.com>
Co-authored-by: Markus Staab <markus.staab@redaxo.de>

Author: phpstan-bot

phpstan-baseline.neon

@@ -150,12 +150,6 @@ parameters:
 			count: 1
 			path: src/Collectors/Registry.php
 
-		-
-			rawMessage: Anonymous function has an unused use $container.
-			identifier: closure.unusedUse
-			count: 1
-			path: src/Command/CommandHelper.php
-
 		-
 			rawMessage: 'Call to static method expand() of internal class Nette\DI\Helpers from outside its root namespace Nette.'
 			identifier: staticMethod.internalClass
@@ -771,12 +765,6 @@ parameters:
 			count: 1
 			path: src/Testing/LevelsTestCase.php
 
-		-
-			rawMessage: Anonymous function has an unused use $container.
-			identifier: closure.unusedUse
-			count: 1
-			path: src/Testing/PHPStanTestCase.php
-
 		-
 			rawMessage: 'Doing instanceof PHPStan\Type\ConstantScalarType is error-prone and deprecated. Use Type::isConstantScalarValue() or Type::getConstantScalarTypes() or Type::getConstantScalarValues() instead.'
 			identifier: phpstanApi.instanceofType

src/Rules/UnusedFunctionParametersCheck.php

@@ -79,6 +79,9 @@ private function getUsedVariables(Scope $scope, $node): array
 					return $scope->getDefinedVariables();
 				}
 			}
+			if ($node instanceof Node\Expr\Include_ || $node instanceof Node\Expr\Eval_) {
+				return $scope->getDefinedVariables();
+			}
 			if ($node instanceof Variable && is_string($node->name) && $node->name !== 'this') {
 				return [$node->name];
 			}

tests/PHPStan/Rules/Classes/UnusedConstructorParametersRuleTest.php

@@ -76,4 +76,9 @@ public function testBug11454(): void
 		$this->analyse([__DIR__ . '/data/bug-11454.php'], []);
 	}
 
+	public function testParameterUsedInIncludedFile(): void
+	{
+		$this->analyse([__DIR__ . '/data/unused-constructor-parameters-include.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Classes/data/unused-constructor-parameters-include.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace UnusedConstructorParametersInclude;
+
+class Foo
+{
+
+	public function __construct(
+		$usedInIncludedFile
+	)
+	{
+		require_once __DIR__ . '/foo.php';
+	}
+
+}

tests/PHPStan/Rules/Functions/data/unused-closure-uses.php

@@ -11,3 +11,17 @@ function ($anotherUnused) use ($usedInClosureUse) {
 		echo $anotherUnused; // different scope
 	};
 };
+
+$container = new stdClass();
+
+function () use ($container) {
+	require_once __DIR__ . '/foo.php';
+};
+
+function () use ($container) {
+	include 'foo.php';
+};
+
+function () use ($container) {
+	eval('echo $container;');
+};