simplify

Author: staabm

src/Analyser/NodeScopeResolver.php

@@ -3300,22 +3300,6 @@ private function processParamNode(
 		$this->callNodeCallback($nodeCallback, new UsedAsStringNode($param->default), $scope, $storage);
 	}
 
-	/**
-	 * Whether the native type is a string slot: a plain `string` or a union that
-	 * contains a `string` member (e.g. `string|int`). Plain `mixed` is not a string
-	 * slot, so arguments to untyped parameters do not fire.
-	 */
-	private function isStringSlotType(Type $type): bool
-	{
-		foreach (TypeUtils::flattenTypes($type) as $slotMemberType) {
-			if ($slotMemberType->isString()->yes()) {
-				return true;
-			}
-		}
-
-		return false;
-	}
-
 	/**
 	 * @param AttributeGroup[] $attrGroups
 	 * @param callable(Node $node, Scope $scope): void $nodeCallback
@@ -3759,7 +3743,7 @@ public function processArgs(
 				$argStringSlotType = $parameterNativeType ?? ($parameter instanceof NativeParameterReflection ? $parameter->getType() : null);
 				if (
 					$argStringSlotType !== null
-					&& $this->isStringSlotType($argStringSlotType)
+					&& !$argStringSlotType->isString()->no()
 					&& !ExprUsedAsStringVisitor::isAlreadyUsedAsStringSite($arg->value)
 				) {
 					$this->callNodeCallback($nodeCallback, new UsedAsStringNode($arg->value), $scopeToPass, $storage);