Report invalid $flags constants for preg_replace_callback() and preg_replace_callback_array() (#6019)

Co-authored-by: staabm <120441+staabm@users.noreply.github.com>

Author: phpstan-bot

resources/constantToFunctionParameterMap.php

@@ -140,6 +140,26 @@
 		],
 	],
 
+	'preg_replace_callback' => [
+		'flags' => [
+			'type' => 'bitmask',
+			'constants' => [
+				'PREG_OFFSET_CAPTURE',
+				'PREG_UNMATCHED_AS_NULL',
+			],
+		],
+	],
+
+	'preg_replace_callback_array' => [
+		'flags' => [
+			'type' => 'bitmask',
+			'constants' => [
+				'PREG_OFFSET_CAPTURE',
+				'PREG_UNMATCHED_AS_NULL',
+			],
+		],
+	],
+
 	// ————————————————————————————————————————————
 	// Sorting
 	// ————————————————————————————————————————————

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -2887,6 +2887,14 @@ public function testConstantParameterCheck(): void
 				'Constant JSON_THROW_ON_ERROR is not allowed for parameter #3 $depth of function json_decode.',
 				99,
 			],
+			[
+				'Constant PREG_SPLIT_NO_EMPTY is not allowed for parameter #6 $flags of function preg_replace_callback.',
+				110,
+			],
+			[
+				'Constant PREG_SPLIT_NO_EMPTY is not allowed for parameter #5 $flags of function preg_replace_callback_array.',
+				119,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Functions/data/constant-parameter-check.php

@@ -105,3 +105,18 @@ public function hashPassword(string $password): string
 
 // PHP_OS passed to $subject of preg_match - should not report
 preg_match('/foo/', PHP_OS);
+
+// preg_replace_callback: wrong constant in $flags
+preg_replace_callback('/foo/', fn ($m) => $m[0], 'subject', -1, $count, PREG_SPLIT_NO_EMPTY);
+
+// preg_replace_callback: correct constant in $flags
+preg_replace_callback('/foo/', fn ($m) => $m[0], 'subject', -1, $count, PREG_OFFSET_CAPTURE);
+
+// preg_replace_callback: correct bitmask in $flags
+preg_replace_callback('/foo/', fn ($m) => $m[0], 'subject', -1, $count, PREG_OFFSET_CAPTURE | PREG_UNMATCHED_AS_NULL);
+
+// preg_replace_callback_array: wrong constant in $flags
+preg_replace_callback_array(['/foo/' => fn ($m) => $m[0]], 'subject', -1, $count, PREG_SPLIT_NO_EMPTY);
+
+// preg_replace_callback_array: correct constant in $flags
+preg_replace_callback_array(['/foo/' => fn ($m) => $m[0]], 'subject', -1, $count, PREG_UNMATCHED_AS_NULL);