Cover the configured range check and the analysed-version floor for PHP_VERSION_ID < X guards

A Composer constraint without a lower bound keeps the guard's full range,
and an analysed version below the guard stays the floor.

Author: HawkForge

tests/PHPStan/Rules/Classes/InvalidPromotedPropertiesRulePhpVersionRangeTest.php

@@ -0,0 +1,38 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Classes;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use PHPUnit\Framework\Attributes\RequiresPhp;
+
+/**
+ * @extends RuleTestCase<InvalidPromotedPropertiesRule>
+ */
+class InvalidPromotedPropertiesRulePhpVersionRangeTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new InvalidPromotedPropertiesRule();
+	}
+
+	#[RequiresPhp('>= 8.0.0')]
+	public function testBug15425(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-15425-range.php'], [
+			[
+				'Promoted properties are supported only on PHP 8.0 and later.',
+				10,
+			],
+		]);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/invalidPromotedPropertiesPhpVersionRange.neon',
+		];
+	}
+
+}

tests/PHPStan/Rules/Classes/InvalidPromotedPropertiesRuleTest.php

@@ -144,7 +144,12 @@ public function testConditionallyDeclaredClass(): void
 	#[RequiresPhp('>= 8.0.0')]
 	public function testBug15425(): void
 	{
-		$this->analyse([__DIR__ . '/data/bug-15425.php'], []);
+		$this->analyse([__DIR__ . '/data/bug-15425.php'], [
+			[
+				'Promoted properties are supported only on PHP 8.0 and later.',
+				19,
+			],
+		]);
 	}
 
 }

tests/PHPStan/Rules/Classes/ReadOnlyClassRulePhp81Test.php

@@ -0,0 +1,38 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Classes;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use PHPUnit\Framework\Attributes\RequiresPhp;
+
+/**
+ * @extends RuleTestCase<ReadOnlyClassRule>
+ */
+class ReadOnlyClassRulePhp81Test extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new ReadOnlyClassRule();
+	}
+
+	#[RequiresPhp('>= 8.2.0')]
+	public function testBug15425(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-15425-readonly.php'], [
+			[
+				'Readonly classes are supported only on PHP 8.2 and later.',
+				8,
+			],
+		]);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/readOnlyClassPhp81.neon',
+		];
+	}
+
+}

tests/PHPStan/Rules/Classes/data/bug-15425-composer/composer.json

@@ -0,0 +1,5 @@
+{
+	"require": {
+		"php": "<8.4"
+	}
+}

tests/PHPStan/Rules/Classes/data/bug-15425-range.php

@@ -0,0 +1,14 @@
+<?php // lint >= 8.0
+
+declare(strict_types = 1);
+
+namespace Bug15425Range;
+
+if (PHP_VERSION_ID < 80300) {
+	final class Foo
+	{
+		public function __construct(public ?string $message = null)
+		{
+		}
+	}
+}

tests/PHPStan/Rules/Classes/data/bug-15425-readonly.php

@@ -0,0 +1,11 @@
+<?php // lint >= 8.2
+
+declare(strict_types = 1);
+
+namespace Bug15425Readonly;
+
+if (PHP_VERSION_ID < 80400) {
+	final readonly class Foo
+	{
+	}
+}

tests/PHPStan/Rules/Classes/data/bug-15425.php

@@ -5,12 +5,19 @@
 namespace Bug15425;
 
 if (PHP_VERSION_ID < 80400) {
-	\PHPStan\dumpType(PHP_VERSION_ID);
-
 	final class Foo
 	{
 		public function __construct(public ?string $message = null)
 		{
 		}
 	}
 }
+
+if (PHP_VERSION_ID < 80000) {
+	final class Bar
+	{
+		public function __construct(public ?string $message = null)
+		{
+		}
+	}
+}

tests/PHPStan/Rules/Classes/invalidPromotedPropertiesPhpVersionRange.neon

@@ -0,0 +1,4 @@
+parameters:
+	# composer.json "php": "<8.4" gives a version range without a lower bound
+	composerAutoloaderProjectPaths:
+		- %rootDir%/tests/PHPStan/Rules/Classes/data/bug-15425-composer

tests/PHPStan/Rules/Classes/readOnlyClassPhp81.neon

@@ -0,0 +1,2 @@
+parameters:
+	phpVersion: 80100