Clarify ternary branch-inspection test: benevolent vs strict string|false

The previous `falsePositive` case used `stream_get_contents()`, which returns a
*benevolent* string|false. PHPStan intentionally accepts benevolent unions for a
string parameter, so the equivalent direct call is error-free too — and reporting
the branch would re-introduce the very pg_escape_bytea false positive this branch
inspection guards against (its second `string` parameter is fed the same
`stream_get_contents()` benevolent union).

Document that no-error case precisely and add a companion `strictFalseBranchReported`
showing that a *strict* (non-benevolent) string|false branch under the same
asymmetric `is_resource()` narrowing IS reported. This makes branch inspection's
consistency with PHPStan's standard accept semantics explicit.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: 2 people

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -2989,6 +2989,10 @@ public function testBug11281(): void
 				'Parameter #1 $i of function Bug11281Functions\sayHello expects int, string given.',
 				35,
 			],
+			[
+				'Parameter #1 $s of function Bug11281Functions\expectsString expects string, string|false given.',
+				64,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Functions/data/bug-11281.php

@@ -39,14 +39,30 @@ function expectsString(string $s): void
 {
 }
 
-function falsePositive(mixed $value): void
+function benevolentBranchNotReported(mixed $value): void
 {
-	// is_resource() only narrows asymmetrically (@phpstan-assert-if-true), so the
-	// else branch must keep the type the ternary actually produces (mixed, accepted),
-	// not a spurious narrowing. No error should be reported here.
+	// stream_get_contents() returns a *benevolent* string|false. PHPStan intentionally
+	// accepts benevolent unions for a string parameter, so the equivalent direct call
+	// expectsString(stream_get_contents($r)) is error-free too — reporting it here would
+	// re-introduce the pg_escape_bytea false positive this branch inspection guards
+	// against. is_resource() also narrows asymmetrically (@phpstan-assert-if-true only),
+	// so the else branch must keep the type the ternary actually produces (mixed,
+	// accepted) instead of a spurious narrowing. No error should be reported here.
 	expectsString(
 		is_resource($value)
 			? stream_get_contents($value)
 			: $value,
 	);
 }
+
+function strictFalseBranchReported(mixed $value, string|false $sf): void
+{
+	// A *strict* (non-benevolent) string|false branch is not accepted by the string
+	// parameter, so branch inspection reports it even though is_resource() narrows
+	// asymmetrically and the ternary's resulting type normalizes to mixed.
+	expectsString(
+		is_resource($value)
+			? $sf
+			: $value,
+	);
+}