33namespace PHPStan \Rules \Variables ;
44
55use PhpParser \Node ;
6+ use PHPStan \Analyser \CollectedDataEmitter ;
7+ use PHPStan \Analyser \NodeCallbackInvoker ;
68use PHPStan \Analyser \Scope ;
79use PHPStan \DependencyInjection \AutowiredParameter ;
810use PHPStan \DependencyInjection \RegisteredRule ;
911use PHPStan \Node \CoalesceExpressionNode ;
12+ use PHPStan \Rules \Comparison \ConstantConditionInTraitHelper ;
1013use PHPStan \Rules \IdentifierRuleError ;
1114use PHPStan \Rules \IssetCheck ;
1215use PHPStan \Rules \Rule ;
@@ -23,6 +26,7 @@ final class NullCoalesceRule implements Rule
2326
2427 public function __construct (
2528 private IssetCheck $ issetCheck ,
29+ private ConstantConditionInTraitHelper $ constantConditionInTraitHelper ,
2630 #[AutowiredParameter(ref: '%featureToggles.unnecessaryNullCoalesce% ' )]
2731 private bool $ unnecessaryNullCoalesce ,
2832 )
@@ -34,10 +38,11 @@ public function getNodeType(): string
3438 return CoalesceExpressionNode::class;
3539 }
3640
37- public function processNode (Node $ node , Scope $ scope ): array
41+ public function processNode (Node $ node , Scope & NodeCallbackInvoker & CollectedDataEmitter $ scope ): array
3842 {
43+ $ subjectResult = $ node ->getSubjectResult ();
3944 $ error = $ this ->issetCheck ->check (
40- $ node -> getSubjectResult () ,
45+ $ subjectResult ,
4146 $ scope ,
4247 $ node ->getOperatorDescription (),
4348 'nullCoalesce ' ,
@@ -53,18 +58,21 @@ static function (Type $type): ?string {
5358
5459 return 'is not nullable ' ;
5560 },
56- );
61+ ) ?? $ this -> checkUnnecessaryNullCoalesce ( $ node , $ scope ) ;
5762
58- if ($ error !== null ) {
59- return [$ error ];
63+ if ($ error === null ) {
64+ $ this ->constantConditionInTraitHelper ->emitNoError (self ::class, $ scope , $ subjectResult ->getExpr ());
65+ return [];
6066 }
6167
62- $ unnecessaryError = $ this ->checkUnnecessaryNullCoalesce ($ node , $ scope );
63- if ($ unnecessaryError !== null ) {
64- return [$ unnecessaryError ];
68+ if ($ scope ->isInTrait ()) {
69+ // The error messages already distinguish the possible outcomes,
70+ // so the contexts only need to be told apart by error/no error.
71+ $ this ->constantConditionInTraitHelper ->emitError (self ::class, $ scope , $ subjectResult ->getExpr (), true , $ error );
72+ return [];
6573 }
6674
67- return [];
75+ return [$ error ];
6876 }
6977
7078 private function checkUnnecessaryNullCoalesce (CoalesceExpressionNode $ node , Scope $ scope ): ?IdentifierRuleError
0 commit comments