Ignore @no-named-arguments in the native type of variadic parameters

The native type of a variadic parameter used acceptsNamedArguments(),
which comes from the @no-named-arguments PHPDoc tag. That contradicts
getNativeType(), which is documented as ignoring PHPDoc, and makes an
@phpstan-assert on such a parameter report as redundant under
treatPhpDocTypesAsCertain: false.

Only the PHPDoc-aware type now uses acceptsNamedArguments(). The native
type keeps string keys whenever the PHP version supports named arguments.

Author: GromNaN

src/Analyser/MutatingScope.php

@@ -2240,7 +2240,10 @@ private function enterFunctionLike(
 
 			$nativeParameterType = $parameter->getNativeType();
 			if ($parameter->isVariadic()) {
-				if (!$this->getPhpVersion()->supportsNamedArguments()->no() && $functionReflection->acceptsNamedArguments()->yes()) {
+				// acceptsNamedArguments() is read from PHPDoc, so it must not narrow the native type.
+				// PHP still accepts named arguments (and therefore string keys) at runtime,
+				// even when the function is marked with @no-named-arguments.
+				if (!$this->getPhpVersion()->supportsNamedArguments()->no()) {
 					$nativeParameterType = new ArrayType(new UnionType([IntegerRangeType::createAllGreaterThanOrEqualTo(0), new StringType()]), $nativeParameterType);
 				} else {
 					$nativeParameterType = new IntersectionType([new ArrayType(IntegerRangeType::createAllGreaterThanOrEqualTo(0), $nativeParameterType), new AccessoryArrayListType()]);

tests/PHPStan/Analyser/nsrt/no-named-arguments.php

@@ -11,7 +11,7 @@
 function noNamedArgumentsInFunction(float ...$args)
 {
 	assertType('list<float>', $args);
-	assertNativeType('list<float>', $args);
+	assertNativeType('array<int<0, max>|string, float>', $args);
 }
 
 class Baz extends Foo implements Bar
@@ -22,19 +22,19 @@ class Baz extends Foo implements Bar
 	public function noNamedArgumentsInMethod(float ...$args)
 	{
 		assertType('list<float>', $args);
-		assertNativeType('list<float>', $args);
+		assertNativeType('array<int<0, max>|string, float>', $args);
 	}
 
 	public function noNamedArgumentsInParent(float ...$args)
 	{
 		assertType('list<float>', $args);
-		assertNativeType('list<float>', $args);
+		assertNativeType('array<int<0, max>|string, float>', $args);
 	}
 
 	public function noNamedArgumentsInInterface(float ...$args)
 	{
 		assertType('list<float>', $args);
-		assertNativeType('list<float>', $args);
+		assertNativeType('array<int<0, max>|string, float>', $args);
 	}
 }
 

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeStaticMethodCallRuleTest.php

@@ -207,6 +207,13 @@ public function testInTrait(): void
 		]);
 	}
 
+	#[RequiresPhp('>= 8.0.0')]
+	public function testNoNamedArgumentsNativeTypeWithUncertainPhpDocTypes(): void
+	{
+		$this->treatPhpDocTypesAsCertain = false;
+		$this->analyse([__DIR__ . '/data/no-named-arguments-native-type.php'], []);
+	}
+
 	public static function getAdditionalConfigFiles(): array
 	{
 		return [

tests/PHPStan/Rules/Comparison/data/no-named-arguments-native-type.php

@@ -0,0 +1,39 @@
+<?php // lint >= 8.0
+declare(strict_types = 1);
+
+namespace NoNamedArgumentsNativeType;
+
+final class QueryBuilder
+{
+
+	/**
+	 * @no-named-arguments
+	 */
+	public function select(mixed ...$select): void
+	{
+		self::validateVariadicParameter($select);
+	}
+
+	/**
+	 * @no-named-arguments
+	 */
+	public function groupBy(string ...$groupBy): void
+	{
+		self::validateVariadicParameter($groupBy);
+	}
+
+	/**
+	 * @template TItem
+	 * @param TItem[] $parameter
+	 * @phpstan-assert list<TItem> $parameter
+	 */
+	private static function validateVariadicParameter(array $parameter): void
+	{
+		if (array_is_list($parameter)) {
+			return;
+		}
+
+		throw new \InvalidArgumentException();
+	}
+
+}

turbo-ext/src/MutatingScope.cpp

@@ -4512,8 +4512,10 @@ class MutatingScope
 			zv::Val nativeParameterType = pt_type_call(parameterObject, PT_LC("getnativetype"), 0, NULL);
 			if (UNEXPECTED(nativeParameterType.isUndef())) return zv::Val();
 			if (zend_is_true(isVariadic.raw())) {
+				/* acceptsNamedArguments() is read from PHPDoc, so it must not narrow
+				 * the native type: PHP still accepts named arguments at runtime. */
 				bool named;
-				if (UNEXPECTED(!acceptsNamedArgumentsHere(reflection, named))) return zv::Val();
+				if (UNEXPECTED(!phpVersionSupportsNamedArguments(named))) return zv::Val();
 				zv::Val wrapped = variadicArrayType(nativeParameterType.raw(), named);
 				if (UNEXPECTED(wrapped.isUndef())) return zv::Val();
 				nativeParameterType = std::move(wrapped);