Treat the float 2**63 as above every int in IntegerRangeType factories

A float compared with PHP_INT_MAX compares against the float 2**63, so
`$value > PHP_INT_MAX` is false for exactly 2**63. createAllSmallerThan()
and createAllGreaterThanOrEqualTo() then cast 2**63 to int, which emits
"not representable as an int" and yields NeverType / int<min, max>
instead of int / NeverType. Use `>=` like the other two factories do.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Author: zonuexe

src/Type/IntegerRangeType.php

@@ -90,7 +90,7 @@ public static function createAllSmallerThan($value): Type
 			return self::fromInterval(null, $value, -1);
 		}
 
-		if ($value > PHP_INT_MAX) {
+		if ($value >= PHP_INT_MAX) {
 			return new IntegerType();
 		}
 
@@ -160,7 +160,7 @@ public static function createAllGreaterThanOrEqualTo($value): Type
 			return new IntegerType();
 		}
 
-		if ($value > PHP_INT_MAX) {
+		if ($value >= PHP_INT_MAX) {
 			return new NeverType();
 		}
 

tests/PHPStan/Analyser/nsrt/integer-range-float-two-to-the-63.php

@@ -0,0 +1,43 @@
+<?php declare(strict_types = 1);
+
+namespace IntegerRangeFloatTwoToThe63;
+
+use function PHPStan\Testing\assertType;
+
+function smaller(int $i): void
+{
+	if ($i < 9.2233720368547758E18) {
+		assertType('int', $i);
+	} else {
+		assertType('*NEVER*', $i);
+	}
+	assertType('int', $i);
+}
+
+function greaterOrEqual(int $i): void
+{
+	if ($i >= 9.2233720368547758E18) {
+		assertType('*NEVER*', $i);
+	} else {
+		assertType('int', $i);
+	}
+	assertType('int', $i);
+}
+
+function smallerOrEqual(int $i): void
+{
+	if ($i <= 9.2233720368547758E18) {
+		assertType('int', $i);
+	} else {
+		assertType('*NEVER*', $i);
+	}
+}
+
+function greater(int $i): void
+{
+	if ($i > 9.2233720368547758E18) {
+		assertType('*NEVER*', $i);
+	} else {
+		assertType('int', $i);
+	}
+}

tests/PHPStan/Type/IntegerRangeTypeTest.php

@@ -0,0 +1,48 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type;
+
+use Closure;
+use PHPStan\Testing\PHPStanTestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
+
+class IntegerRangeTypeTest extends PHPStanTestCase
+{
+
+	public static function dataCreateFromFloat(): iterable
+	{
+		// 2**63 is PHP_INT_MAX + 1, the smallest float greater than every int
+		yield '< 2**63' => [IntegerRangeType::createAllSmallerThan(...), 9.2233720368547758E18, 'int'];
+		yield '<= 2**63' => [IntegerRangeType::createAllSmallerThanOrEqualTo(...), 9.2233720368547758E18, 'int'];
+		yield '> 2**63' => [IntegerRangeType::createAllGreaterThan(...), 9.2233720368547758E18, '*NEVER*'];
+		yield '>= 2**63' => [IntegerRangeType::createAllGreaterThanOrEqualTo(...), 9.2233720368547758E18, '*NEVER*'];
+
+		// the largest float smaller than 2**63
+		yield '< 2**63 - 1024' => [IntegerRangeType::createAllSmallerThan(...), 9.2233720368547748E18, 'int<min, 9223372036854774783>'];
+		yield '<= 2**63 - 1024' => [IntegerRangeType::createAllSmallerThanOrEqualTo(...), 9.2233720368547748E18, 'int<min, 9223372036854774784>'];
+		yield '> 2**63 - 1024' => [IntegerRangeType::createAllGreaterThan(...), 9.2233720368547748E18, 'int<9223372036854774785, max>'];
+		yield '>= 2**63 - 1024' => [IntegerRangeType::createAllGreaterThanOrEqualTo(...), 9.2233720368547748E18, 'int<9223372036854774784, max>'];
+
+		// -2**63 is exactly PHP_INT_MIN
+		yield '< -2**63' => [IntegerRangeType::createAllSmallerThan(...), -9.2233720368547758E18, '*NEVER*'];
+		yield '<= -2**63' => [IntegerRangeType::createAllSmallerThanOrEqualTo(...), -9.2233720368547758E18, '-9223372036854775808'];
+		yield '> -2**63' => [IntegerRangeType::createAllGreaterThan(...), -9.2233720368547758E18, 'int<-9223372036854775807, max>'];
+		yield '>= -2**63' => [IntegerRangeType::createAllGreaterThanOrEqualTo(...), -9.2233720368547758E18, 'int'];
+
+		// the largest float smaller than -2**63
+		yield '< -2**63 - 2048' => [IntegerRangeType::createAllSmallerThan(...), -9.2233720368547779E18, '*NEVER*'];
+		yield '<= -2**63 - 2048' => [IntegerRangeType::createAllSmallerThanOrEqualTo(...), -9.2233720368547779E18, '*NEVER*'];
+		yield '> -2**63 - 2048' => [IntegerRangeType::createAllGreaterThan(...), -9.2233720368547779E18, 'int'];
+		yield '>= -2**63 - 2048' => [IntegerRangeType::createAllGreaterThanOrEqualTo(...), -9.2233720368547779E18, 'int'];
+	}
+
+	/**
+	 * @param Closure(float): Type $factory
+	 */
+	#[DataProvider('dataCreateFromFloat')]
+	public function testCreateFromFloat(Closure $factory, float $value, string $expected): void
+	{
+		$this->assertSame($expected, $factory($value)->describe(VerbosityLevel::precise()));
+	}
+
+}