Remove nodeScopeResolverReflector service

It was only needed so that the stub validator container could point
NodeScopeResolver to a different reflector. Since the stub validator
now overrides the source locator instead, the service is just an alias
of betterReflectionReflector, which is what a plain Reflector type-hint
autowires to anyway.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017DjgMHgfvwhD4ogdTaRtLp

Author: ondrejmirtes

conf/services.neon

@@ -246,10 +246,6 @@ services:
 		autowired:
 			- PHPStan\Reflection\ReflectionProvider
 
-	nodeScopeResolverReflector:
-		factory: @betterReflectionReflector
-		autowired: false
-
 	# not registered using attributes because people often override it
 
 	exceptionTypeResolver:

src/Analyser/NodeScopeResolver.php

@@ -214,7 +214,6 @@ public function __construct(
 		private readonly Container $container,
 		private readonly ReflectionProvider $reflectionProvider,
 		private readonly InitializerExprTypeResolver $initializerExprTypeResolver,
-		#[AutowiredParameter(ref: '@nodeScopeResolverReflector')]
 		private readonly Reflector $reflector,
 		private readonly ClassReflectionFactory $classReflectionFactory,
 		private readonly ParameterOutTypeExtensionProvider $parameterOutTypeExtensionProvider,