Repository navigation
Commit 9effa00
Serve a parse error from the autoload trap where OPcache would keep its empty script
AutoloadSourceLocator locates a class not yet loaded by running the
autoloaders under FileReadTrapStreamWrapper, which records the file an
autoloader includes and serves an empty script in its place. With
OPcache active that empty script is compiled and cached under the path
the include was given; the locator invalidates the trapped files
afterwards, but on PHP < 8.1 opcache_invalidate() fails for the path of
any stream wrapper other than file:// - zend_accel_invalidate() resolves
the path first and php_resolve_path() refuses such URLs (8.1 falls back
to the name as given). The poisoned entry then answers every later real
include of the same path, the class is never declared, and its first
cold use dies with "Class not found".
PHPStan's own classes that preload.php leaves to the autoloader (the
turbo-shadowed ones, TrinaryLogic among them) are exactly such files when
running from the phar - autoloaded as
phar://.../vendor/composer/../../src/TrinaryLogic.php by the phar's
Composer classmap - and analysing code that references them triggers the
trap. Spawned workers on PHP 7.4 and 8.0 started running with OPcache in
the previous commit, which is how the extension test suites hit it.
Where the invalidation cannot work, the trap now serves a parse error
instead: it compiles to nothing, so OPcache stores nothing, and the
locator catches the ParseError - the file was recorded before the
include compiled it. Everywhere else the empty script stays, so
autoloaders that require several files in a row keep being captured in
full.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VdGL6QPGhAzYmN2zU4gwhH1 parent 100834a commit 9effa00
3 files changed
Lines changed: 103 additions & 1 deletion
File tree
- src/Reflection/BetterReflection/SourceLocator
- tests/PHPStan/Reflection/BetterReflection/SourceLocator
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
343 | 344 | | |
344 | 345 | | |
345 | 346 | | |
346 | | - | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
347 | 354 | | |
348 | 355 | | |
349 | 356 | | |
| |||
367 | 374 | | |
368 | 375 | | |
369 | 376 | | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
370 | 380 | | |
371 | 381 | | |
372 | 382 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| 15 | + | |
| 16 | + | |
13 | 17 | | |
14 | 18 | | |
15 | 19 | | |
| |||
40 | 44 | | |
41 | 45 | | |
42 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
43 | 57 | | |
44 | 58 | | |
45 | 59 | | |
46 | 60 | | |
| 61 | + | |
| 62 | + | |
47 | 63 | | |
48 | 64 | | |
49 | 65 | | |
| |||
102 | 118 | | |
103 | 119 | | |
104 | 120 | | |
| 121 | + | |
105 | 122 | | |
106 | 123 | | |
107 | 124 | | |
| |||
119 | 136 | | |
120 | 137 | | |
121 | 138 | | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
122 | 143 | | |
123 | 144 | | |
124 | 145 | | |
125 | 146 | | |
126 | 147 | | |
127 | 148 | | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
128 | 188 | | |
129 | 189 | | |
130 | 190 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
0 commit comments