Skip to content

Commit aeef59f

Browse files
ondrejmirtesclaude
andcommitted
Use backslash-separated source paths in config.w32
confutils' ADD_SOURCES derives each object's directory by splitting on backslashes only; with forward slashes the objects compiled flat into the build directory while the link response file expected them under src\, failing with LNK1181. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013j6ePxd1BobZkr8YVLnNet
1 parent 755a3dd commit aeef59f

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

‎turbo-ext/config.w32‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,13 @@ if (PHP_PHPSTAN_TURBO != "no") {
1515
// generated parser action files exceed the default section limit.
1616
// The version is passed as a bare token (main.cpp stringizes it) —
1717
// quote characters do not survive the configure-to-nmake pipeline.
18-
// The version is passed as a bare token (main.cpp stringizes it) —
19-
// quote characters do not survive the configure-to-nmake pipeline.
2018
var flags = "/std:c++17 /EHsc /bigobj /DPHPSTANTURBO_VERSION_RAW=" + version;
2119

20+
// backslash-separated paths: confutils' ADD_SOURCES derives the object
21+
// directory by splitting on backslashes only — with forward slashes the
22+
// objects compile flat while the link list expects the subpath
2223
EXTENSION("phpstan_turbo",
23-
"src/main.cpp src/support.cpp src/CombinationsHelper.cpp src/ConditionalExpressionHolder.cpp src/ExpressionTypeHolder.cpp src/NodeScanner.cpp src/NodeTraverser.cpp src/ScopeOps.cpp src/TrinaryLogic.cpp src/TypeCombinatorCache.cpp",
24+
"src\\main.cpp src\\support.cpp src\\CombinationsHelper.cpp src\\ConditionalExpressionHolder.cpp src\\ExpressionTypeHolder.cpp src\\NodeScanner.cpp src\\NodeTraverser.cpp src\\ScopeOps.cpp src\\TrinaryLogic.cpp src\\TypeCombinatorCache.cpp",
2425
true,
2526
flags);
2627
ADD_SOURCES(configure_module_dirname + "/src/parser",

0 commit comments

Comments
 (0)