Skip to content

Commit baa7845

Browse files
committed
Pass the skipped rule callbacks of finalize() positionally
simple-downgrader cannot downgrade a named argument that skips optional parameters. Amp-Thread-ID: https://ampcode.com/threads/T-01a183fb-60aa-75ff-ae8f-f11d56a3eb08
1 parent dda126f commit baa7845

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎src/Command/FixerWorkerRunner.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ function (array $errors, array $locallyIgnoredErrors, array $analysedFiles) use
197197
false,
198198
true,
199199
);
200-
$finalizerResult = $this->analyserResultFinalizer->finalize($resultCacheResult->getAnalyserResult(), $isOnlyFiles, false, previousCollectedDataRuleResults: $resultCache->getCollectedDataRuleResults());
200+
$finalizerResult = $this->analyserResultFinalizer->finalize($resultCacheResult->getAnalyserResult(), $isOnlyFiles, false, null, null, $resultCache->getCollectedDataRuleResults());
201201
$resultCacheResult->save($finalizerResult->getCollectedDataRuleResults());
202202

203203
$internalErrors = [];

‎tests/PHPStan/Analyser/CollectedDataRuleReuseTest.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ private function finalize(array $rules, array $collectedData, bool $onlyFiles, a
312312
reachedInternalErrorsCountLimit: false,
313313
peakMemoryUsageBytes: 0,
314314
processedFiles: [],
315-
), $onlyFiles, false, previousCollectedDataRuleResults: $previousResults);
315+
), $onlyFiles, false, null, null, $previousResults);
316316
}
317317

318318
/**

0 commit comments

Comments
 (0)