Refactor

Author: VincentLanglet

src/Analyser/RuleErrorTransformer.php

@@ -76,7 +76,7 @@ public function transform(
 		) {
 			$line = $ruleError->getLine();
 		} else {
-			$line = $this->getLineFromNode($node);
+			$line = self::getLineFromNode($node);
 		}
 		if (
 			$ruleError instanceof FileRuleError
@@ -168,10 +168,10 @@ public function transform(
 		);
 	}
 
-	private function getLineFromNode(Node $node): int
+	public static function getLineFromNode(Node $node): int
 	{
 		if ($node instanceof PropertyAssignNode) {
-			return $this->getLineFromNode($node->getPropertyFetch());
+			return self::getLineFromNode($node->getPropertyFetch());
 		}
 
 		if (

src/Rules/FunctionCallParametersCheck.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PHPStan\Analyser\MutatingScope;
+use PHPStan\Analyser\RuleErrorTransformer;
 use PHPStan\Analyser\Scope;
 use PHPStan\DependencyInjection\AutowiredParameter;
 use PHPStan\DependencyInjection\AutowiredService;
@@ -89,11 +90,7 @@ public function check(
 		string $namedArgumentMessage,
 	): array
 	{
-		if ($funcCall instanceof Node\Expr\MethodCall || $funcCall instanceof Node\Expr\StaticCall || $funcCall instanceof Node\Expr\FuncCall) {
-			$funcCallLine = $funcCall->name->getStartLine();
-		} else {
-			$funcCallLine = $funcCall->getStartLine();
-		}
+		$funcCallLine = RuleErrorTransformer::getLineFromNode($funcCall);
 
 		$functionParametersMinCount = 0;
 		$functionParametersMaxCount = 0;