Fix tests for PHP versions below 8.4

SplFixedArray::setSize() has the tentative return type true only since
PHP 8.4. The SOAP E2E fixture is analysed in a PHP 8.2+ range from
composer.json, so its implicitly nullable parameter is now reported as
deprecated in PHP 8.4; declare it explicitly nullable instead.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1b1b9-0a7d-772a-a8bb-331fd76aa9cc

Author: ondrejmirtes

tests/PHPStan/Rules/Methods/OverridingMethodRuleTest.php

@@ -143,11 +143,14 @@ public function testOverridingFinalMethod(int $phpVersion, string $contravariant
 
 		if (PHP_VERSION_ID >= 80100) {
 			$tip = 'Make it covariant, or use the #[\ReturnTypeWillChange] attribute to temporarily suppress the error.';
-			$errors[] = [
-				'Return type bool of method OverridingFinalMethod\FixedArray::setSize() is not covariant with tentative return type true of method SplFixedArray<mixed>::setSize().',
-				125,
-				$tip,
-			];
+			if (PHP_VERSION_ID >= 80400) {
+				// SplFixedArray::setSize() has the tentative return type true since PHP 8.4, bool before
+				$errors[] = [
+					'Return type bool of method OverridingFinalMethod\FixedArray::setSize() is not covariant with tentative return type true of method SplFixedArray<mixed>::setSize().',
+					125,
+					$tip,
+				];
+			}
 			$errors[] = [
 				'Return type mixed of method OverridingFinalMethod\SomeIterator::getIterator() is not covariant with tentative return type Traversable of method IteratorAggregate<int,OverridingFinalMethod\Foo>::getIterator().',
 				250,

tests/e2e/data/soap.php

@@ -29,7 +29,7 @@ class MySoapClient3 extends \SoapClient
 	 * @param string|null $wsdl
 	 * @param mixed[]|null $options
 	 */
-	public function __construct($wsdl, array $options = null)
+	public function __construct($wsdl, ?array $options = null)
 	{
 		parent::SoapClient($wsdl, $options);
 	}