You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d72de75
Browse filesBrowse the repository at this point in the historyBrowse files
Three ways the new tests did not survive the 7.4 job:
- The name scope collecting visitor was an anonymous class taking the result array as a
by-reference promoted property. simple-downgrade expands promotion into a plain assignment,
which drops the reference, so the caller kept its empty array. It is a named test class now
and hands the scopes back through a getter.
- The property hooks in exported-properties-hooks.php do not parse below 8.4 - the parser
follows the analysed PHP version, which defaults to the running one - so the test that needs
them is marked #[RequiresPhp('>= 8.4.0')].
- That data file is not in the lint exclude list either, so its first line carries `// lint >= 8.4`.
Verified against a downgraded tree on a real php 7.4 binary, not just the php-parser grammar.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VDcVRMjAXM7WQGSzysw7WH
0 commit comments