Repository navigation
Commit dabbfe7
Reset NodeCallbackScope ask memos when cloning scopes natively
The native scopeWith() derives scopes by cloning and resetting
per-instance memo properties to their fresh-constructor defaults - the
PHP twin's duplicateWith() constructs a fresh scope instead, so any
memo the reset list misses survives cloning only under turbo.
NodeCallbackScope's list was stale twice over: truthyValueExprs and
falseyValueExprs no longer exist (replaced by the ordered scopeOps
list), and the askedTypes/askedNativeTypes ask memos were never listed -
a rule that asked a node's type, derived a scope (assignExpression(),
filterByTruthyValue(), ...), and asked again read the pre-derivation
answer back from the cloned memo instead of replaying the recorded ops.
NodeCallbackScopeDerivedOpsRuleTest caught it on every turbo CI job.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GnwgpaeUXRkgSDyg95tfK81 parent 37a4aee commit dabbfe7
1 file changed
Lines changed: 9 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
79 | 80 | | |
80 | 81 | | |
81 | 82 | | |
82 | | - | |
83 | | - | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
84 | 86 | | |
85 | 87 | | |
86 | 88 | | |
| |||
303 | 305 | | |
304 | 306 | | |
305 | 307 | | |
306 | | - | |
307 | | - | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
308 | 311 | | |
309 | 312 | | |
310 | 313 | | |
| |||
0 commit comments