Do not export what is declared inside a function or method body

A define() or a class declared inside a function or method body is
not found from other files, and ExportedNodeVisitor does not look
inside function bodies. Exporting it during the analysis made every
edit of its file look like a symbol disappeared, so all files with
errors were re-analysed.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Author: 2 people

.github/workflows/e2e-tests.yml

@@ -442,6 +442,19 @@ jobs:
               echo "$INFO"
               ../bashunit -a equals 'true' "$(echo "$INFO" | jq --raw-output '.resultCacheUsed')"
               ../bashunit -a equals '1' "$(echo "$INFO" | jq --raw-output '.filesToAnalyseCount')"
+          - script: |
+              cd e2e/result-cache-define-in-function
+              OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan analyse -vv --error-format raw")
+              echo "$OUTPUT"
+              ../bashunit -a contains 'Other.php:10:Method ResultCacheE2EDefineInFunction\Other::doOther() should return int but returns string.' "$OUTPUT"
+              # A define() inside a function or method body is not an exported node, so an edit of the
+              # file calling it looks like no symbol appeared or disappeared: only the file itself is
+              # re-analysed, not every file with errors.
+              patch -b src/functions.php < body.patch
+              INFO=$(../../bin/phpstan result-cache-info --json)
+              echo "$INFO"
+              ../bashunit -a equals 'true' "$(echo "$INFO" | jq --raw-output '.resultCacheUsed')"
+              ../bashunit -a equals '1' "$(echo "$INFO" | jq --raw-output '.filesToAnalyseCount')"
           - script: |
               cd e2e/result-cache-function-shares-method-name
               OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan analyse -vv --error-format raw")

e2e/result-cache-define-in-function/body.patch

@@ -0,0 +1,11 @@
+--- src/functions.php
++++ src/functions.php
+@@ -6,7 +6,7 @@
+ {
+ 	define('RESULT_CACHE_E2E_IN_FUNCTION', 1);
+ 
+-	return 1;
++	return 2;
+ }
+ 
+ class Bootstrap

e2e/result-cache-define-in-function/phpstan.neon

@@ -0,0 +1,5 @@
+parameters:
+	level: 8
+	tmpDir: tmp
+	paths:
+		- src

e2e/result-cache-define-in-function/src/Other.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace ResultCacheE2EDefineInFunction;
+
+class Other
+{
+
+	public function doOther(): int
+	{
+		return 'foo';
+	}
+
+}

e2e/result-cache-define-in-function/src/functions.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace ResultCacheE2EDefineInFunction;
+
+function setUp(): int
+{
+	define('RESULT_CACHE_E2E_IN_FUNCTION', 1);
+
+	return 1;
+}
+
+class Bootstrap
+{
+
+	public function boot(): void
+	{
+		define('RESULT_CACHE_E2E_IN_METHOD', 1);
+	}
+
+}

e2e/result-cache-define-in-function/tmp/.gitignore

@@ -0,0 +1,2 @@
+*
+!.*

src/Dependency/DependencyResolver.php

@@ -96,10 +96,11 @@ public function resolveExportedNode(Node $node, Scope $scope): ?RootExportedNode
 			$this->nameScopeTracker->enterNode($node);
 		}
 
-		// A function declared inside another function is not supported (function.inner), and the
-		// restore does not look inside function bodies for exported nodes (ExportedNodeVisitor):
-		// exporting it here would make every edit of its file look like a symbol disappeared.
-		if (($nodeProfile & self::PROFILE_EXPORT) === 0 || ($node instanceof Node\Stmt\Function_ && $scope->getFunction() !== null)) {
+		// Nothing declared inside a function or method body is a symbol other files can use: a function
+		// declared there is not supported (function.inner), and a class or a define() there is not found.
+		// The restore does not look inside function bodies for exported nodes (ExportedNodeVisitor), so
+		// exporting one here would make every edit of its file look like a symbol disappeared.
+		if (($nodeProfile & self::PROFILE_EXPORT) === 0 || $scope->getFunction() !== null) {
 			return null;
 		}