Cover the constant rename sequence on a scanned file

The same seven steps as e2e/result-cache-autoloaded-constant, on a file in
scanDirectories: a constant renamed to one the class already declares,
renamed to something else, broken the same way again, put back, then a
syntax error and its fix. Every step re-analyses the one file using the
constant, and the dumped type is back at the end - the scannedFiles
metadata brings the files with errors back even where the dependency edge
was lost.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WvMWsNHbCdSgx97Y56XYcU

Author: ondrejmirtes

.github/workflows/e2e-tests.yml

@@ -297,6 +297,52 @@ jobs:
               echo "$OUTPUT"
               ../bashunit -a contains 'Result cache restored. 1 file will be reanalysed.' "$OUTPUT"
               ../bashunit -a contains 'Foo.php:10:Call to method doDep() on an unknown class ResultCacheE2EScanned2\Dep.' "$OUTPUT"
+          - script: |
+              cd e2e/result-cache-scanned-constant
+              OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan analyse -vv --error-format raw")
+              echo "$OUTPUT"
+              ../bashunit -a contains 'Foo.php:10:Dumped type: 1' "$OUTPUT"
+              # The constant is renamed to one the class already declares. The file is invalid PHP, but
+              # the class still reflects, so the file using the constant is re-analysed through its
+              # dependency edge.
+              patch -b scanned/Dep.php < duplicate.patch
+              OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan analyse -vv --error-format raw")
+              echo "$OUTPUT"
+              ../bashunit -a contains 'Result cache restored. 1 file will be reanalysed.' "$OUTPUT"
+              ../bashunit -a contains 'Foo.php:10:Access to undefined constant ResultCacheE2EScannedConstant\Dep::CON.' "$OUTPUT"
+              # Renamed to something else instead.
+              mv scanned/Dep.php.orig scanned/Dep.php
+              patch -b scanned/Dep.php < renamed.patch
+              OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan analyse -vv --error-format raw")
+              echo "$OUTPUT"
+              ../bashunit -a contains 'Result cache restored. 1 file will be reanalysed.' "$OUTPUT"
+              ../bashunit -a contains 'Foo.php:10:Access to undefined constant ResultCacheE2EScannedConstant\Dep::CON.' "$OUTPUT"
+              # Broken the same way again.
+              mv scanned/Dep.php.orig scanned/Dep.php
+              patch -b scanned/Dep.php < duplicate.patch
+              OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan analyse -vv --error-format raw")
+              echo "$OUTPUT"
+              ../bashunit -a contains 'Result cache restored. 1 file will be reanalysed.' "$OUTPUT"
+              ../bashunit -a contains 'Foo.php:10:Access to undefined constant ResultCacheE2EScannedConstant\Dep::CON.' "$OUTPUT"
+              # And put back the way it was.
+              mv scanned/Dep.php.orig scanned/Dep.php
+              OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan analyse -vv --error-format raw")
+              echo "$OUTPUT"
+              ../bashunit -a contains 'Result cache restored. 1 file will be reanalysed.' "$OUTPUT"
+              ../bashunit -a contains 'Foo.php:10:Dumped type: 1' "$OUTPUT"
+              # A syntax error makes the class disappear altogether: the file using it reports an unknown
+              # class and records no dependency edge to the file, so nothing but the file being fixed can
+              # bring the file using it back - it must be re-analysed once the class is there again.
+              patch -b scanned/Dep.php < broken.patch
+              OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan analyse -vv --error-format raw")
+              echo "$OUTPUT"
+              ../bashunit -a contains 'Result cache restored. 1 file will be reanalysed.' "$OUTPUT"
+              ../bashunit -a contains 'Foo.php:10:Access to constant CON on an unknown class ResultCacheE2EScannedConstant\Dep.' "$OUTPUT"
+              mv scanned/Dep.php.orig scanned/Dep.php
+              OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan analyse -vv --error-format raw")
+              echo "$OUTPUT"
+              ../bashunit -a contains 'Result cache restored. 1 file will be reanalysed.' "$OUTPUT"
+              ../bashunit -a contains 'Foo.php:10:Dumped type: 1' "$OUTPUT"
           - script: |
               cd e2e/result-cache-scanned-new-file
               OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan analyse -vv --error-format raw")

e2e/result-cache-scanned-constant/broken.patch

@@ -0,0 +1,10 @@
+--- scanned/Dep.php
++++ scanned/Dep.php
+@@ -7,6 +7,6 @@
+ 
+ 	public const EXISTING = 'existing';
+ 
+-	public const CON = 1;
++	public const = 1;
+ 
+ }

e2e/result-cache-scanned-constant/duplicate.patch

@@ -0,0 +1,10 @@
+--- scanned/Dep.php
++++ scanned/Dep.php
+@@ -7,6 +7,6 @@
+ 
+ 	public const EXISTING = 'existing';
+ 
+-	public const CON = 1;
++	public const EXISTING = 1;
+ 
+ }

e2e/result-cache-scanned-constant/phpstan.neon

@@ -0,0 +1,7 @@
+parameters:
+	level: 8
+	tmpDir: tmp
+	paths:
+		- src
+	scanDirectories:
+		- scanned

e2e/result-cache-scanned-constant/renamed.patch

@@ -0,0 +1,10 @@
+--- scanned/Dep.php
++++ scanned/Dep.php
+@@ -7,6 +7,6 @@
+ 
+ 	public const EXISTING = 'existing';
+ 
+-	public const CON = 1;
++	public const RENAMED = 1;
+ 
+ }

e2e/result-cache-scanned-constant/scanned/Dep.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace ResultCacheE2EScannedConstant;
+
+class Dep
+{
+
+	public const EXISTING = 'existing';
+
+	public const CON = 1;
+
+}

e2e/result-cache-scanned-constant/src/Foo.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace ResultCacheE2EScannedConstant;
+
+class Foo
+{
+
+	public function doFoo(): void
+	{
+		\PHPStan\dumpType(Dep::CON);
+	}
+
+}

e2e/result-cache-scanned-constant/tmp/.gitignore

@@ -0,0 +1,2 @@
+*
+!.*