Skip to content

infer type on strict comparison with get_class() #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
staabm wants to merge 1 commit into from
Closed

infer type on strict comparison with get_class() #1616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions src/Analyser/TypeSpecifier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,15 +329,7 @@ public function specifyTypesInCondition(
&& isset($exprNode->getArgs()[0])
&& $constantType instanceof ConstantStringType
) {
return $this->specifyTypesInCondition(
$scope,
new Instanceof_(
$exprNode->getArgs()[0]->value,
new Name($constantType->getValue()),
),
$context,
$rootExpr,
);
return $this->specifyTypesInCondition($scope, new Expr\BinaryOp\Identical($expr->left, $expr->right), $context, $rootExpr);
}
}

Expand Down Expand Up @@ -1042,6 +1034,23 @@ private function specifyTypesForConstantStringBinaryExpression(
}
}

if (
$exprNode instanceof FuncCall
&& $exprNode->name instanceof Name
&& strtolower($exprNode->name->toString()) === 'get_class'
&& isset($exprNode->getArgs()[0])
) {
return $this->specifyTypesInCondition(
$scope,
new Instanceof_(
$exprNode->getArgs()[0]->value,
new Name($constantType->getValue()),
),
$context,
$rootExpr,
);
}

if (
$exprNode instanceof FuncCall
&& $exprNode->name instanceof Name
Expand Down
1 change: 1 addition & 0 deletions tests/PHPStan/Analyser/NodeScopeResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,6 +1053,7 @@ public function dataFileAsserts(): iterable
yield from $this->gatherAssertTypes(__DIR__ . '/data/array-offset-unset.php');
yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8008.php');
yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-5552.php');
yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-1239.php');
}

/**
Expand Down
23 changes: 23 additions & 0 deletions tests/PHPStan/Analyser/data/bug-1239.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<?php

namespace Bug1239;

use function PHPStan\Testing\assertType;

class Foo
{
public function __construct()
{
if (get_class($this) === Bar::class) {

@staabm staabm Aug 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just working on one of the different calltypes of bug 1239.
will work on the other types in separate PRs

assertType('$this(Bug1239\Foo)&Bug1239\Bar', $this);
$this->bat();
}
}
}

class Bar extends Foo
{
public function bat(): void
{
}
}