Repository navigation
Improve type inference for $object::class === static::class - #1761
Draft
rvanvelzen wants to merge 1 commit into
Draft
rvanvelzen wants to merge 1 commit into
rvanvelzen wants to merge 1 commit into
Conversation
rvanvelzen
marked this pull request as draft
September 26, 2022 12:38
staabm
reviewed
Sep 26, 2022
Contributor
rvanvelzen
force-pushed
the
static-class-const-equals
branch
from
September 26, 2022 13:41
5d4fc09 to
5154e11
Compare
staabm
reviewed
Sep 26, 2022
| $rootExpr, | ||
| ); | ||
| } | ||
| if ( |
Contributor
There was a problem hiding this comment.
if you move this block into the upper if ($expressions !== null) { block, it would work independent of operand order.
atm the code only works for if ($other::class === static::class) {, within the upper IF it would also work for if (static::class === $other::class) {
rvanvelzen
force-pushed
the
static-class-const-equals
branch
from
October 25, 2022 13:45
5154e11 to
8cc986c
Compare
ondrejmirtes
force-pushed
the
static-class-const-equals
branch
from
October 31, 2026 13:43
8cc986c to
f707077
Compare
ondrejmirtes
force-pushed
the
static-class-const-equals
branch
from
October 31, 2026 13:49
f707077 to
2dda630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.