Repository navigation
Fix #14124: Reassigning to array<string, list<T>> out parameter does not see the list<T> property during assignment - #5006
Merged
Merged
Conversation
- Pass correctly computed valueToWrite type to VariableAssignNode instead of the assignedPropertyExpr expression tree which loses list types on nested array dimension assignments - The assignedPropertyExpr uses setOffsetValueType for non-outermost dims, losing AccessoryArrayListType, while produceArrayDimFetchAssignValueToWrite correctly uses setExistingOffsetValueType via cross-paired dim fetch checks - New regression test in tests/PHPStan/Rules/Variables/data/bug-14124.php Closes phpstan/phpstan#14124
staabm
marked this pull request as ready for review
February 20, 2026 08:42
Collaborator
|
This pull request has been marked as ready for review. |
VincentLanglet
approved these changes
Feb 20, 2026
VincentLanglet
left a comment
VincentLanglet
left a comment
Contributor
There was a problem hiding this comment.
There is two tests and three place you modify the code ; does every change is covered ?
This reverts commit 0d142ab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inspired by #4999
Fixes phpstan/phpstan#14124