Repository navigation
Cover dynamic static calls in tests - #5009
Merged
Merged
Conversation
staabm
marked this pull request as ready for review
February 20, 2026 16:31
Collaborator
|
This pull request has been marked as ready for review. |
Comment on lines
+33
to
+34
| $finalFoo::doFoo(); // could be "Call to static method .. on a separate line has no effect", because final class | ||
| $bar::finalFoo(); // could be "Call to static method .. on a separate line has no effect", because final method |
Contributor
There was a problem hiding this comment.
I'm not sure to understand the PR.
Is it worth covering this with a test with missing expectation ?
Or do you plan fixing this in the next PR ? (Then should it fix in the same ?)
Contributor
Author
There was a problem hiding this comment.
the PR is asserting the current state of things so we see when we change existing behaviour.
I think the possible
"Call to static method .. on a separate line has no effect"
are hardly useful, but they would not be wrong when they start to appear. (for 2 of the 3 examples)
VincentLanglet
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lets add coverage for this scenario with more basic classes which do not depend on phpversion (like DateTimeImmutable via phpstorm stubs)