[staabm]

optimize primitives for speed

[VincentLanglet]

Do you have stat of the gain ?

[staabm]

no.

it removes 1 method call and 1 iteration over all operands for every changed operation.
its very similar in characteristics to the other PRs recently merged

[staabm]

before

➜  phpstan-src git:(2.1.x) ✗ hyperfine 'vendor/bin/phpunit tests/PHPStan/Analyser/AnalyserIntegrationTest.php --filter testBug14100'
Benchmark 1: vendor/bin/phpunit tests/PHPStan/Analyser/AnalyserIntegrationTest.php --filter testBug14100
  Time (mean ± σ):      1.695 s ±  0.021 s    [User: 1.521 s, System: 0.168 s]
  Range (min … max):    1.673 s …  1.731 s    10 runs

after

➜  phpstan-src git:(faster334) ✗ hyperfine 'vendor/bin/phpunit tests/PHPStan/Analyser/AnalyserIntegrationTest.php --filter testBug14100'
Benchmark 1: vendor/bin/phpunit tests/PHPStan/Analyser/AnalyserIntegrationTest.php --filter testBug14100
  Time (mean ± σ):      1.665 s ±  0.008 s    [User: 1.500 s, System: 0.160 s]
  Range (min … max):    1.656 s …  1.684 s    10 runs

[phpstan-bot]

This pull request has been marked as ready for review.

[VincentLanglet]

it removes 1 method call and 1 iteration over all operands for every changed operation. its very similar in characteristics to the other PRs recently merged

Sure, I do agree it improve the perf ; I was curious how much