[eyupcanakman]

Summary

Dynamic throw type extensions only fire on the first union member when the receiver is a union, so dead-catch detection on Foo|DateTime misses throws declared on either side.

Root cause

MethodThrowPointHelper::getThrowPoint passes the UnionTypeMethodReflection straight to each extension's isMethodSupported. The reflection forwards getDeclaringClass() to methods[0], so any extension that branches on the declaring class only sees the first inner method.

Fix

Special-case UnionTypeMethodReflection in the helper. Iterate inner methods, recurse, and union the resulting throw types via TypeCombinator::union. The combined point is explicit if any inner point was; otherwise implicit.

Test

Regression fixture at tests/PHPStan/Rules/Exceptions/data/bug-14467.php. The user-defined class FQN must sort after \DateTime so methods[0] exposes the bug at the rule level.

Closes phpstan/phpstan#14467

[phpstan-bot]

You've opened the pull request against the latest branch 2.2.x. PHPStan 2.2 is not going to be released for months. If your code is relevant on 2.1.x and you want it to be released sooner, please rebase your pull request and change its target to 2.1.x.

[VincentLanglet]

I will prefer having the review from @ondrejmirtes on such PR, because I feel like there is maybe a more general fix to introduce.

There is multiple way to handle this, like yours or

• introducing DynamicMethodThrowTypeExtension::getClass like other extension
• introducing a ExtendedMethodReflection::getDeclaringClasses (and maybe getDeclaringClass will need to be migrated)

Let's see what he think about it

[ondrejmirtes]

I don't love this solution. Other places solve this with $typeWithMethod->getObjectClassNames() like MethodCallReturnTypeHelper. We should be consistent. instanceof UnionTypeMethodReflection doesn't work for plenty of reasons, it can easily break.