Repository navigation
Conversation
VincentLanglet
approved these changes
Sep 19, 2026
ondrejmirtes
force-pushed
the
fix/regex-mandatory-group-offsets
branch
from
October 31, 2026 13:31
48adf11 to
5f51c6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PREG_OFFSET_CAPTUREgroups.-1for potentially unmatched groups and add focused regression coverage.Closes phpstan/phpstan#14959
Validation
php vendor/bin/phpunit tests/PHPStan/Analyser/NodeScopeResolverTest.php --filter bug-14959make tests && make phpstanmake lint && make cs && composer validate --no-interaction