Skip to content

Use faster strspn() over regex matching #7005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 1 commit into from
Nov 9, 2026
+7 −2
Merged

Use faster strspn() over regex matching #7005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Rules/Whitespace/FileWhitespaceRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace PHPStan\Rules\Whitespace;

use Nette\Utils\Strings;
use Override;
use PhpParser\Node;
use PhpParser\NodeTraverser;
Expand All @@ -15,6 +14,8 @@
use PHPStan\Rules\RuleErrorBuilder;
use function array_last;
use function count;
use function strlen;
use function strspn;

/**
* @implements Rule<FileNode>
Expand Down Expand Up @@ -85,7 +86,11 @@ public function getLastNodes(): array
$lastNodes = $visitor->getLastNodes();
$lastNodes[] = array_last($nodes);
foreach ($lastNodes as $lastNode) {
if (!$lastNode instanceof Node\Stmt\InlineHTML || Strings::match($lastNode->value, '#^(\s+)$#') === null) {
if (
!$lastNode instanceof Node\Stmt\InlineHTML
|| $lastNode->value === ''
|| strspn($lastNode->value, " \t\n\r\v\f") !== strlen($lastNode->value)
) {
continue;
}

Expand Down
Loading