Repository navigation
Add build rule declaring native types from PHPDoc types - #7009
Open
ondrejmirtes wants to merge 4 commits into
Open
ondrejmirtes wants to merge 4 commits into
ondrejmirtes wants to merge 4 commits into
Conversation
Reports parameters, return types and properties without a native type when their PHPDoc type can be declared natively, and fixes them: declares the native type and removes the PHPDoc tag when the native type says the same. Return and property types are added only where nothing can override them, parameter types only when contravariant with the overridden methods. Amp-Thread-ID: https://ampcode.com/threads/T-01a1bed4-966e-7640-a834-06bba746e1f1
Fixed by MissingNativeTypeRule, now registered in build/phpstan.neon. The turbo extension declarations are regenerated for the shadowed classes whose signatures changed. The native MutatingScope::pushInFunctionCall() declares the same parameter type as NodeCallbackScope's override, and the native IntegerRangeType::createAll*() accept only int|float like their twin. Amp-Thread-ID: https://ampcode.com/threads/T-01a1bed4-966e-7640-a834-06bba746e1f1
Parameters of non-private methods in @api classes or tagged @api keep their PHPDoc types, as do non-private properties of @api classes. Standalone null, true, false, never and DNF types are not added because build/downgrade.php cannot lower them for PHP 7.4-8.1. Amp-Thread-ID: https://ampcode.com/threads/T-01a1bed4-966e-7640-a834-06bba746e1f1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
MissingNativeTypeRuleto the build rules and applies its fixes to phpstan-src.For each parameter, return type and property without a native type, the rule converts the PHPDoc type with
Type::toNativePhpTypeNode()and checks it by resolving the node back withParserNodeTypeToPHPStanType:@apiinterfaces and non-final classes do not break their implementerscallable)@apiclasses or methods tagged@api(constructors excepted), no types on non-private properties of@apiclassesnull,true,false,neveror DNF types, becausebuild/downgrade.phpcannot lower them for PHP 7.4–8.1PhpDocEditoronly when the native type says exactly the same and the tag has no description; an explicitmixed[]stays next toarraySkipped: by-reference parameters, magic methods other than
__construct/__invoke, traits, defaults the native type would not accept, and multi-property statements.The other commits are the output of
bin/phpstan --fix, plus:MutatingScope::pushInFunctionCall()declares the same parameter type asNodeCallbackScope's override, otherwise the extension fails to loadVerified locally:
make phpstan, the full test suite with and without the extension,signature-parity.php,smoke.php,side-by-side.php, and byte-identical level 10 analysis ofsrc/with the extension on and off.