Repository navigation
Clone and print only the nodes that a fix changes - #7015
Open
SanderMuller wants to merge 1 commit into
Open
SanderMuller wants to merge 1 commit into
SanderMuller wants to merge 1 commit into
Conversation
For each fixable error, fix() cloned every node of the file and printed the whole file again. PathCloningVisitor now clones only the fixed nodes and their parents. Each other node stays the original object, and PhpPrinter copies its original code without printing its children. The original nodes get themselves as origNode while the fix is printed, and lose the attribute again afterwards. When a fix adds a class name, SharedNodeCloningVisitor clones the whole tree first, because NameResolver and NewClassNamesVisitor change nodes in place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For each fixable error,
RuleErrorTransformer::fix()clones every node of the file and prints the whole file again. So a file with many fixable errors takes time that grows faster than the number of errors.PathCloningVisitornow clones only the fixed nodes and their parents. Each other node stays the original object and gets itself as itsorigNode.PhpPrinter::p()copies the original code of such a node without printing its children. After printing,restoreOriginalNodes()removes the attribute again, because the original nodes belong to the analysed AST.When a fix adds a class name or changes a PHPDoc,
SharedNodeCloningVisitorfirst clones the whole tree, becauseNameResolverandNewClassNamesVisitorchange nodes in place.Analysis time with the result cache cleared, hyperfine with 8 runs each, PHP 8.5, macOS arm64:
bug-14996.php)bug-14996.php6 times)On both files,
--fixgives the same output as 2.3.x, byte for byte.RenameFunctionRuleis a new test rule. The analysis reaches each function after the fixes of the functions above it. So the test fails when a fix leaves a node of the analysed AST marked as its ownorigNode, for example withoutrestoreOriginalNodes().The first fix in a file still takes the old path, because it detects the indentation. A file without an indented line takes the old path for each fix.
This came up in phpstan/phpstan-strict-rules#349.
🤖 Generated with Claude Code