Skip to content

Add purge_deferred management command - #183

Open
thorrak wants to merge 2 commits into
pinax:masterfrom
thorrak:master
Open

Add purge_deferred management command#183
thorrak wants to merge 2 commits into
pinax:masterfrom
thorrak:master

Conversation

@thorrak

@thorrak thorrak commented May 31, 2025

Copy link
Copy Markdown

This PR adds a new purge_deferred Django management command which purges any deferred messages.

This is intended for a scenario where you have had an authentication/connectivity issue with the mail server, and messages have backed up in the queue that you no longer want to send.

This PR updates the version number to 2.3.3.

@spookylukey spookylukey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, sorry it has taken me so long to look at this. Just one set of changes requested, see below.

Comment on lines +16 to +20
if options["cron"]:
warnings.warn(
"purge_deferred's -c/--cron option is no longer necessary and will be removed in a future release",
DeprecationWarning,
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are adding a new command, is there a need to add a --cron option, only to immediately deprecate it? Can this and the CronArgMixin be removed? The tests could be updated similarly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants