fix(tests): Update test mocks to patch auth.get_current_access_token

Commit acc403b changed the import pattern from:
  from .auth import get_current_access_token
to:
  from . import auth
  # then calling auth.get_current_access_token()

This was necessary to fix HTTP authentication in streamable-http transport,
where the http_auth_integration module patches auth.get_current_access_token
at runtime to inject tokens from HTTP headers.

The old import pattern created local references that bypassed the runtime
patching, breaking HTTP authentication. The new pattern ensures all calls
go through the auth module, allowing the HTTP auth patching to work.

However, tests were still patching 'api.get_current_access_token' and
'duplication.get_current_access_token', which no longer exist with the new
pattern. This caused 86 test failures.

This commit updates all test mocks to patch at the source:
  @patch('meta_ads_mcp.core.auth.get_current_access_token')

This is the correct approach as it:
1. Preserves HTTP authentication functionality
2. Mocks at the source where the function is actually defined
3. Aligns with how the code actually calls the function

Result: All 257 tests now pass (was 86 failures, 147 passes)

Files updated:
- 12 test files with updated mock paths
- Removed temporary compatibility imports from api.py and duplication.py

Author: nictuku

tests/test_account_info_access_fix.py

@@ -38,7 +38,7 @@ async def test_account_info_direct_access_success(self):
         }
 
         with patch('meta_ads_mcp.core.accounts.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = mock_account_response
 
@@ -95,7 +95,7 @@ async def test_account_info_permission_error_with_helpful_message(self):
         }
 
         with patch('meta_ads_mcp.core.accounts.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
 
                 # First call returns permission error, second call returns accessible accounts
@@ -158,7 +158,7 @@ async def test_account_info_non_permission_error_passthrough(self):
         }
 
         with patch('meta_ads_mcp.core.accounts.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = mock_error_response
 
@@ -180,7 +180,7 @@ async def test_account_info_non_permission_error_passthrough(self):
     async def test_account_info_missing_account_id_error(self):
         """Test that missing account_id parameter returns appropriate error"""
 
-        with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+        with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
             mock_auth.return_value = "test_access_token"
 
             result = await get_account_info(account_id=None)
@@ -207,7 +207,7 @@ async def test_account_info_act_prefix_handling(self):
         }
 
         with patch('meta_ads_mcp.core.accounts.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = mock_account_response
 
@@ -236,7 +236,7 @@ async def test_account_info_european_dsa_detection(self):
         }
 
         with patch('meta_ads_mcp.core.accounts.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = mock_account_response
 
@@ -272,7 +272,7 @@ async def test_regression_basic_account_info_still_works(self):
         }
 
         with patch('meta_ads_mcp.core.accounts.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = mock_account_response
 

tests/test_budget_update.py

@@ -40,7 +40,7 @@ def mock_api_request(self):
     def mock_auth_manager(self):
         """Mock for the authentication manager"""
         with patch('meta_ads_mcp.core.api.auth_manager') as mock, \
-             patch('meta_ads_mcp.core.api.get_current_access_token') as mock_get_token:
+             patch('meta_ads_mcp.core.auth.get_current_access_token') as mock_get_token:
             # Mock a valid access token
             mock.get_current_access_token.return_value = "test_access_token"
             mock.is_token_valid.return_value = True
@@ -433,7 +433,7 @@ async def test_budget_update_workflow(self):
         # Test that the function accepts the new parameters
         with patch('meta_ads_mcp.core.adsets.make_api_request') as mock_api, \
              patch('meta_ads_mcp.core.api.auth_manager') as mock_auth, \
-             patch('meta_ads_mcp.core.api.get_current_access_token') as mock_get_token:
+             patch('meta_ads_mcp.core.auth.get_current_access_token') as mock_get_token:
 
             mock_api.return_value = {"id": "test_id", "daily_budget": "5000"}
             mock_auth.get_current_access_token.return_value = "test_access_token"

tests/test_dsa_beneficiary.py

@@ -30,7 +30,7 @@ async def test_dsa_requirement_detection_business_account(self):
         }
 
         with patch('meta_ads_mcp.core.accounts.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = mock_account_response
 
@@ -62,7 +62,7 @@ async def test_dsa_requirement_detection_non_dsa_region(self):
         }
 
         with patch('meta_ads_mcp.core.accounts.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = mock_account_response
 
@@ -81,7 +81,7 @@ async def test_dsa_requirement_detection_non_dsa_region(self):
     async def test_dsa_requirement_detection_error_handling(self):
         """Test error handling when account info cannot be retrieved"""
         with patch('meta_ads_mcp.core.accounts.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.side_effect = Exception("API Error")
 
@@ -100,7 +100,7 @@ async def test_dsa_requirement_detection_error_handling(self):
     async def test_account_info_requires_account_id(self):
         """Test that get_account_info requires an account_id parameter"""
 
-        with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+        with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
             mock_auth.return_value = "test_access_token"
 
             # Test without account_id parameter
@@ -140,7 +140,7 @@ async def test_account_info_inaccessible_account_error(self):
         }
 
         with patch('meta_ads_mcp.core.accounts.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 # First call returns permission error, second call returns accessible accounts
                 mock_api.side_effect = [mock_permission_error, mock_accessible_accounts]
@@ -175,7 +175,7 @@ async def test_create_adset_with_dsa_beneficiary_success(self):
         }
 
         with patch('meta_ads_mcp.core.adsets.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = mock_response
 
@@ -209,7 +209,7 @@ async def test_create_adset_with_dsa_beneficiary_validation_error(self):
         }
 
         with patch('meta_ads_mcp.core.adsets.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.side_effect = Exception("DSA beneficiary required for European compliance")
 
@@ -237,7 +237,7 @@ async def test_create_adset_with_dsa_beneficiary_validation_error(self):
     async def test_create_adset_without_dsa_beneficiary_dsa_required(self):
         """Test error when DSA beneficiary is required but not provided"""
         with patch('meta_ads_mcp.core.adsets.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.side_effect = Exception("Enter the person or organization that benefits from ads in this ad set")
 
@@ -265,7 +265,7 @@ async def test_create_adset_without_dsa_beneficiary_dsa_required(self):
     async def test_create_adset_dsa_beneficiary_in_targeting(self):
         """Test that DSA beneficiary is not added to targeting spec"""
         with patch('meta_ads_mcp.core.adsets.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = {"id": "23842588888640185"}
 
@@ -300,7 +300,7 @@ async def test_create_adset_dsa_beneficiary_parameter_formats(self):
 
         for beneficiary_name in test_cases:
             with patch('meta_ads_mcp.core.adsets.make_api_request', new_callable=AsyncMock) as mock_api:
-                with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+                with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                     mock_auth.return_value = "test_access_token"
                     mock_api.return_value = {"id": "23842588888640185"}
 
@@ -326,7 +326,7 @@ class TestDSAPermissionHandling:
     async def test_dsa_beneficiary_missing_business_management_permission(self):
         """Test error handling when business_management permissions are missing"""
         with patch('meta_ads_mcp.core.adsets.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.side_effect = Exception("Permission denied: business_management permission required")
 
@@ -354,7 +354,7 @@ async def test_dsa_beneficiary_missing_business_management_permission(self):
     async def test_dsa_beneficiary_api_limitation_handling(self):
         """Test handling when API doesn't support dsa_beneficiary parameter"""
         with patch('meta_ads_mcp.core.adsets.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.side_effect = Exception("Parameter dsa_beneficiary is not supported")
 
@@ -397,7 +397,7 @@ async def test_dsa_compliance_european_regions(self):
             }
 
             with patch('meta_ads_mcp.core.accounts.make_api_request', new_callable=AsyncMock) as mock_api:
-                with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+                with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                     mock_auth.return_value = "test_access_token"
                     mock_api.return_value = mock_account_response
 
@@ -422,7 +422,7 @@ async def test_dsa_compliance_non_european_regions(self):
             }
 
             with patch('meta_ads_mcp.core.accounts.make_api_request', new_callable=AsyncMock) as mock_api:
-                with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+                with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                     mock_auth.return_value = "test_access_token"
                     mock_api.return_value = mock_account_response
 
@@ -451,7 +451,7 @@ async def test_dsa_beneficiary_validation_by_region(self):
 
         # Test European account
         with patch('meta_ads_mcp.core.accounts.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = european_mock_response
 
@@ -462,7 +462,7 @@ async def test_dsa_beneficiary_validation_by_region(self):
 
         # Test US account
         with patch('meta_ads_mcp.core.accounts.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = us_mock_response
 
@@ -487,7 +487,7 @@ async def test_dsa_beneficiary_clear_error_message(self):
 
         for error_message, expected_keyword in error_scenarios:
             with patch('meta_ads_mcp.core.adsets.make_api_request', new_callable=AsyncMock) as mock_api:
-                with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+                with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                     mock_auth.return_value = "test_access_token"
                     mock_api.side_effect = Exception(error_message)
 
@@ -514,7 +514,7 @@ async def test_dsa_beneficiary_clear_error_message(self):
     async def test_dsa_beneficiary_fallback_behavior(self):
         """Test fallback behavior for unexpected DSA-related errors"""
         with patch('meta_ads_mcp.core.adsets.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.side_effect = Exception("Unexpected DSA-related error")
 
@@ -562,7 +562,7 @@ async def test_get_adset_details_with_dsa_beneficiary(self):
         }
 
         with patch('meta_ads_mcp.core.adsets.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = mock_adset_response
 
@@ -595,7 +595,7 @@ async def test_get_adset_details_without_dsa_beneficiary(self):
         }
 
         with patch('meta_ads_mcp.core.adsets.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = mock_adset_response
 
@@ -625,7 +625,7 @@ async def test_get_adset_details_empty_dsa_beneficiary(self):
         }
 
         with patch('meta_ads_mcp.core.adsets.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = mock_adset_response
 
@@ -640,7 +640,7 @@ async def test_get_adset_details_empty_dsa_beneficiary(self):
     async def test_get_adset_details_dsa_beneficiary_field_requested(self):
         """Test that the API request includes dsa_beneficiary in the fields parameter"""
         with patch('meta_ads_mcp.core.adsets.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.return_value = {"id": "120229746629010183"}
 
@@ -655,7 +655,7 @@ async def test_get_adset_details_dsa_beneficiary_field_requested(self):
     async def test_get_adset_details_error_handling(self):
         """Test error handling when retrieving ad set details fails"""
         with patch('meta_ads_mcp.core.adsets.make_api_request', new_callable=AsyncMock) as mock_api:
-            with patch('meta_ads_mcp.core.api.get_current_access_token', new_callable=AsyncMock) as mock_auth:
+            with patch('meta_ads_mcp.core.auth.get_current_access_token', new_callable=AsyncMock) as mock_auth:
                 mock_auth.return_value = "test_access_token"
                 mock_api.side_effect = Exception("Ad set not found")