TOML: compact integer underscores without a second char array - #13
Merged
pjfanning merged 1 commit intoAug 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a one-commit JAIPilot Cloud follow-up on the exact current head of FasterXML/jackson-dataformats-text#713. It targets the original contributor branch so the change can be accepted without a duplicate upstream feature PR.
Change
Compact underscores in place in TomlParser.parseInt using the parser-owned token buffer. Characters before the first underscore are already in place, so the slow path no longer allocates and fills a second char array.
Proof
Boundary and disclosure
Only the underscore-bearing slow path changes; integer tokens without underscores are untouched. The allocation fixture forces a very long token and is not a production-throughput claim.
JAIPilot Cloud generated and validated the patch in skrcode/jackson-dataformats-text#2. I reviewed the exact ancestry, complete two-file diff, verification evidence, and limitation before offering it here.