checks: don't rely on set methods of pkg.inherit and pkg.inherited

Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

Author: arthurzam

src/pkgcheck/checks/codingstyle.py

@@ -1006,9 +1006,7 @@ def get_eclass(self, export, pkg):
 
         # last exporting eclass takes precedence for multiple inheritance
         if len(eclass) > 1:
-            if inherited := pkg.inherited.intersection(eclass):
-                eclass = (x for x in reversed(pkg.inherited) if x in inherited)
-            else:
+            if not (eclass := [x for x in reversed(pkg.inherited) if x in eclass]):
                 return
 
         return next(iter(eclass))
@@ -1039,7 +1037,7 @@ def feed(self, pkg):
             if name == "inherit":
                 # register conditional eclasses
                 eclasses = call.split()[1:]
-                if not pkg.inherited.intersection(eclasses):
+                if not any(x in pkg.inherited for x in eclasses):
                     conditional.update(eclasses)
                 continue
             # Also ignore vars since any used in arithmetic expansions, i.e.
@@ -1104,7 +1102,7 @@ def feed(self, pkg):
                     # SRC_URI, S, ...) and no functions
                     unused.discard(eclass)
 
-        for eclass in pkg.inherited.intersection(used):
+        for eclass in (x for x in pkg.inherited if x in used):
             for lineno, name, usage in used[eclass]:
                 if name in self.internals[eclass]:
                     yield InternalEclassUsage(eclass, lineno, usage, pkg=pkg)

src/pkgcheck/checks/eclass.py

@@ -274,7 +274,8 @@ def check_provided_eclasses(self, pkg, inherits: list[tuple[list[str], int]]):
             provided: (eclass, lineno + 1)
             for eclasses, lineno in inherits
             for eclass in eclasses
-            for provided in pkg.inherit.intersection(self.eclass_cache[eclass].provides)
+            for provided in pkg.inherit
+            if provided in self.eclass_cache[eclass].provides
         }
         for provided, (eclass, lineno) in provided_eclasses.items():
             yield ProvidedEclassInherit(eclass, pkg=pkg, line=provided, lineno=lineno)
@@ -308,10 +309,13 @@ def feed(self, pkg):
             yield from self.check_deprecated_variables(pkg, inherits)
             yield from self.check_deprecated_functions(pkg, inherits)
 
-            for eclass in pkg.inherit.intersection(self.dead_eclasses):
-                yield DeadEclass(eclass, pkg=pkg)
+            for eclass in pkg.inherit:
+                if eclass in self.dead_eclasses:
+                    yield DeadEclass(eclass, pkg=pkg)
 
-            for eclass in pkg.inherit.intersection(self.deprecated_eclasses):
+            for eclass in pkg.inherit:
+                if eclass not in self.deprecated_eclasses:
+                    continue
                 replacement = self.deprecated_eclasses[eclass]
                 if not isinstance(replacement, str):
                     replacement = None