UnquotedVariablesCheck: report unquoted variables in [ ] tests

Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

Author: arthurzam

NEWS.rst

@@ -18,6 +18,9 @@ pkgcheck 0.10.47 (unreleased)
 - StableRequestCheck: count from the latest change to a version, not
   sometimes from when it was added (Arthur Zamarin)
 
+- UnquotedVariable: also report variables unquoted inside ``[ ]`` tests (Arthur
+  Zamarin)
+
 -----------------------------
 pkgcheck 0.10.46 (2026-09-26)
 -----------------------------

src/pkgcheck/checks/codingstyle.py

@@ -1391,8 +1391,6 @@ class _UnquotedVariablesCheck(Check):
             # Variable is part of declaring variables, and does not need to be
             # quoted. for example local TMPDIR is ok.
             "declaration_command",
-            # Variable sits inside a [[ ]] test command and it's OK not to be quoted
-            "test_command",
             # Variable is being used in a heredoc body, no need to specify quotes.
             "heredoc_body",
         }
@@ -1403,6 +1401,9 @@ def _var_needs_quotes(self, pkg, node):
         while pnode is not None:
             if pnode.type in self.node_types_ok:
                 return False
+            elif pnode.type == "test_command":
+                # Variable sits inside a [[ ]] test command and it's OK not to be quoted
+                return pnode.children[0].type != "[["
             elif pnode.type == "command":
                 cmd = pkg.node_str(pnode.child_by_field_name("name"))
                 return cmd not in self.message_commands

testdata/data/repos/standalone/EbuildUnquotedVariablesCheck/EbuildUnquotedVariable/expected.json

@@ -1,3 +1,4 @@
 {"__class__": "EbuildUnquotedVariable", "category": "EbuildUnquotedVariablesCheck", "package": "EbuildUnquotedVariable", "version": "0", "variable": "FILESDIR", "lines": [12, 22]}
+{"__class__": "EbuildUnquotedVariable", "category": "EbuildUnquotedVariablesCheck", "package": "EbuildUnquotedVariable", "version": "0", "variable": "S", "lines": [53]}
 {"__class__": "EbuildUnquotedVariable", "category": "EbuildUnquotedVariablesCheck", "package": "EbuildUnquotedVariable", "version": "0", "variable": "T", "lines": [28, 30, 44, 45]}
 {"__class__": "EbuildUnquotedVariable", "category": "EbuildUnquotedVariablesCheck", "package": "EbuildUnquotedVariable", "version": "0", "variable": "WORKDIR", "lines": [37]}

testdata/data/repos/standalone/EbuildUnquotedVariablesCheck/EbuildUnquotedVariable/fix.patch

@@ -2,46 +2,56 @@
 +++ fixed/EbuildUnquotedVariablesCheck/EbuildUnquotedVariable/EbuildUnquotedVariable-0.ebuild	2022-05-18 20:50:00.271294657 +0200
 @@ -9,7 +9,7 @@
  SLOT="0"
-
+ 
  PATCHES=(
 -	${FILESDIR}/foo.patch # FAIL
 +	"${FILESDIR}"/foo.patch # FAIL
  	"${FILESDIR}"/foo.patch # ok
  	"${FILESDIR}/foo.patch" # ok
  )
-@@ -17,28 +17,28 @@
+@@ -19,30 +19,30 @@
  		:
  	fi
-
+ 
 -	if has "foo" ${FILESDIR} ; then # FAIL
 +	if has "foo" "${FILESDIR}" ; then # FAIL
  		:
  	fi
-
+ 
  	local t=${T} # ok
  	local t=${T}/t # ok
 -	emake CC=${T}; someotherfunc ${T} # FAIL
 +	emake CC="${T}"; someotherfunc "${T}" # FAIL
-
+ 
 -	local var=( TMP=${T} ) # FAIL
 +	local var=( TMP="${T}" ) # FAIL
-
+ 
  	cat > "${T}"/somefile <<- EOF || die
  		PATH="${EPREFIX}${INSTALLDIR}/bin"
  	EOF
  	doenvd "${T}"/10stuffit # ok
-
+ 
 -	echo "InitiatorName=$(${WORKDIR}/usr/sbin/iscsi-iname)" # FAIL
 +	echo "InitiatorName=$("${WORKDIR}"/usr/sbin/iscsi-iname)" # FAIL
  	einfo ${WORKDIR} # ok
-
+ 
  	if grep -qs '^ *sshd *:' "${WORKDIR}"/etc/hosts.{allow,deny} ; then # ok
  		ewarn "something something ${WORKDIR} here"
  	fi
-
+ 
 -	cat < ${T} # FAIL
 -	cat >> ${T} # FAIL
 +	cat < "${T}" # FAIL
 +	cat >> "${T}" # FAIL
-
-	local TMPDIR # ok
+ 
+ 	local TMPDIR # ok
+ 	TMPDIR="$(mktemp --directory --tmpdir=/tmp ${PN}-XXXX)" # ok
+@@ -50,7 +50,7 @@
+ 
+ 	unset TMPDIR # ok
+ 
+-	if [ -z ${S} ]; then # FAIL
++	if [ -z "${S}" ]; then # FAIL
+ 		:
+ 	fi
+ 	[ -d "${S}" ] && [[ -d ${S} ]] # ok

testdata/repos/standalone/EbuildUnquotedVariablesCheck/EbuildUnquotedVariable/EbuildUnquotedVariable-0.ebuild

@@ -49,4 +49,9 @@ src_prepare() {
 	export TMPDIR # ok
 
 	unset TMPDIR # ok
+
+	if [ -z ${S} ]; then # FAIL
+		:
+	fi
+	[ -d "${S}" ] && [[ -d ${S} ]] # ok
 }