manifest: accept any path inside a package directory as a target

Only an ebuild or a package directory could be named. Anything else got
handed to path_restrict as-is and parsed as an atom, so pointing at a file
you had just touched failed with a message about the wrong thing entirely:

    $ pkgdev manifest files/some.patch
    pkgdev manifest: error: net-libs/files: missing package version

Resolve a path below a package directory to that package, so naming a
patch, metadata.xml or the Manifest itself manifests the package holding it.

Resolves: #80
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

Author: arthurzam

NEWS.rst

@@ -12,6 +12,12 @@ pkgdev 0.2.17 (unreleased)
   containers and root shells. Per the XDG basedir spec such values are now
   discarded in favor of ``~/.config`` (Arthur Zamarin, #179)
 
+**pkgdev manifest:**
+
+- manifest: any file inside a package directory now manifests that package,
+  so ``pkgdev manifest files/some.patch`` works rather than failing to parse
+  the path as an atom (Arthur Zamarin, #80)
+
 **pkgdev bugs:**
 
 - bugs: bash and zsh completion now complete stabilization groups as targets,

src/pkgdev/scripts/pkgdev_manifest.py

@@ -85,7 +85,10 @@ def _restrict_targets(repo, targets):
         if os.path.exists(target):
             try:
                 if target in repo:
-                    target = os.path.relpath(target, repo.location)
+                    target = os.path.relpath(os.path.realpath(target), repo.location)
+                    # anything else inside a package dir manifests that package
+                    if len(parts := target.split(os.sep)) > 2 and not target.endswith(".ebuild"):
+                        target = os.sep.join(parts[:2])
                 restrictions.append(repo.path_restrict(target))
             except ValueError as exc:
                 manifest.error(exc)

tests/scripts/test_pkgdev_manifest.py

@@ -1,10 +1,12 @@
+import os
 from contextlib import chdir
 from functools import partial
 from os.path import join as pjoin
 from typing import List, Set
 from unittest.mock import patch
 
 import pytest
+from snakeoil.fileutils import touch
 
 from pkgdev.scripts import run
 
@@ -189,6 +191,24 @@ def test_good_manifest(self, capsys, repo):
         out, err = capsys.readouterr()
         assert out == err == ""
 
+    def test_target_within_pkgdir(self, capsys, repo):
+        """Any file inside a package dir manifests that package."""
+        repo.create_ebuild("cat/pkg-0")
+        pkgdir = os.path.dirname(repo.create_ebuild("cat/pkg-1"))
+        os.makedirs(pjoin(pkgdir, "files"), exist_ok=True)
+        touch(pjoin(pkgdir, "files", "a.patch"))
+        for target in ("files/a.patch", "files", "metadata.xml"):
+            touch(pjoin(pkgdir, "metadata.xml"))
+            with (
+                patch("sys.argv", self.args + [target]),
+                pytest.raises(SystemExit) as excinfo,
+                chdir(pkgdir),
+            ):
+                self.script()
+            assert excinfo.value.code == 0
+            out, err = capsys.readouterr()
+            assert err == ""
+
     def test_bad_manifest(self, capsys, repo):
         repo.create_ebuild("cat/pkg-0")
         repo.create_ebuild("cat/pkg-1", eapi="-1")