Commit 2cd7137
committed
spec R39: pin VHH thresholds from TNP source assign_flag()
Spec R39 said VHH PSH/PPC/PNC/totalCdrLength thresholds were "pinned
at M1 from TNP source `bin_*` functions". The values live in
oxpig/TNP `bin/TNP`'s `assign_flag()` function (not `bin_*`, but the
function the spec refers to). Transcribed verbatim with cohortSize 36:
totalCdrLength: bidirectional, green 25-36, amber 20-24 OR 37-39, red <20 OR >39
psh: bidirectional, green 79.60-126.82, amber 73.40-79.59 OR 126.83-155.47, red <73.40 OR >155.47
ppc: high_bad, amber 0.39-1.18, red >1.18
pnc: high_bad, amber 1.47-1.88, red >1.88
cdrh3Compactness: bidirectional, green 0.82-1.56, amber 0.56-0.81 OR 1.57-1.61, red <0.56 OR >1.61
`scoring.py` was falling back to Fv values for the four shared metrics
when mode == TNP. Now uses the VHH dict end-to-end. Citation in the
JSON points to the TNP repo + assign_flag() function name so the
source is traceable.
Minor edge-case correction to the cdrh3Compactness bands: spec text
listed green 0.82-1.57 but TNP source has amber starting at 1.57
(green effectively 0.82-1.56). Source-authoritative.1 parent f8ee498 commit 2cd7137
2 files changed
Lines changed: 34 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
35 | 55 | | |
36 | 56 | | |
37 | | - | |
38 | | - | |
| 57 | + | |
| 58 | + | |
39 | 59 | | |
40 | 60 | | |
41 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
15 | 13 | | |
16 | 14 | | |
17 | 15 | | |
| |||
103 | 101 | | |
104 | 102 | | |
105 | 103 | | |
106 | | - | |
107 | | - | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
108 | 107 | | |
109 | 108 | | |
110 | 109 | | |
| |||
0 commit comments