Commit d4a3569
committed
drop structureId placeholder axis from scores PFrame
The scores PFrame used to declare a `pl7.app/structure/id` axis with a
constant `"static"` value on every row. It was added as a defensive
workaround for what we thought was an xsv-import-pt "at least one axis"
requirement back when the scores frame was emitted via the legacy
single-PDB path. On the PrimaryRef path that's now the only path,
`pframes.processColumn` auto-prepends the upstream PDB column's axes
(`[sampleId, scClonotypeKey]`) to every per-row output, which already
uniquely keys every scores row.
Re-reading `xsv-import-pt.lib.tengo:110-116`, the parquet path's
`PFCONV_IMPORT_CFG_SCHEMA` accepts an empty `axes` array and the
generated polars schema is built from `columns` only when axes is
empty. So the placeholder column was rendering for no reason — it
showed up in the scoresTable as a redundant "Structure" row-axis
cell with the same string `"static"` on every row.
Changes:
- `workflow/src/specs.lib.tengo` — `scoresAxesSpec` is now `[]`,
`buildScoresXsvSettings` returns `axes: []`. Comments rewritten so
the next reader doesn't reintroduce the placeholder.
- `software/src/main.py` — drop `structureId` from `_SCORES_AXES` and
from the `_build_scores_row` dict, drop the `_PLACEHOLDER_STRUCTURE_ID`
constant.
- `workflow/src/process-pdb.tpl.tengo` — refresh the header comment so
it documents the actual current behavior (axes = `[sampleId,
scClonotypeKey]` from prepend, nothing block-side).
NB for local dev: the software image needs rebuilding for the python
change to land at runtime —
`cd software && PL_DOCKER_BUILD=true PL_DOCKER_NO_AUTOPUSH=true pnpm build`.
The workflow-side empty-axes change is forward-compatible with the old
software (pfconv silently ignored undeclared parquet columns), so a
workflow-only deploy still works against a stale image.1 parent d34ecb8 commit d4a3569
3 files changed
Lines changed: 23 additions & 44 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
146 | 145 | | |
147 | 146 | | |
148 | 147 | | |
| |||
183 | 182 | | |
184 | 183 | | |
185 | 184 | | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | 185 | | |
190 | 186 | | |
191 | 187 | | |
| |||
232 | 228 | | |
233 | 229 | | |
234 | 230 | | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | 231 | | |
240 | 232 | | |
241 | 233 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
20 | 18 | | |
21 | 19 | | |
22 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
333 | 333 | | |
334 | 334 | | |
335 | 335 | | |
336 | | - | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
343 | | - | |
344 | | - | |
345 | | - | |
346 | | - | |
347 | | - | |
348 | | - | |
349 | | - | |
350 | | - | |
351 | | - | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
352 | 344 | | |
353 | 345 | | |
354 | 346 | | |
| |||
625 | 617 | | |
626 | 618 | | |
627 | 619 | | |
628 | | - | |
629 | | - | |
630 | | - | |
631 | | - | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
632 | 623 | | |
633 | 624 | | |
634 | | - | |
635 | | - | |
636 | | - | |
| 625 | + | |
637 | 626 | | |
638 | 627 | | |
639 | 628 | | |
| |||
0 commit comments